Make sure customer cookie value is url decoded prior to use #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto components, in php and js/wp-e-commerce Wrapped output to console in test to see if we are in debug mode Added debug mode indicator to localized javascript data when debug mode is enabled at the server Added utility routine to check for debug mode to core Utility routine that checks for debug mode enabled implemented. Debug mode determined to be enabled when WordPress debug mode is enabled via constant definition Debug mode determined to be enabled when WPeC debug mode is enabled via constant definition Debug mode can be enabled/disabled persistently at runtime by a logged in administrative user putting a parameter onto a store url. This will enable WPeC support to enable debug mode via the internet without having to access source code. Conflicts: wpsc-core/js/wp-e-commerce.js
This was referenced Mar 11, 2015
found one more bug, a $ prefixed variable name
Contributor
Author
|
@JustinSainton jshint driven cleanup of changed areas, found and fixed another type/defect |
Member
|
@JeffPyeBrook Can we rebase and get this in 4.0? |
JustinSainton
force-pushed
the
master
branch
from
9868144 to
a97791b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses issue #1786
Make sure customer cookie value is decoded prior to breaking it into components, in php and js/wp-e-commerce
Much console output is being generated in the WPeC javascript, this output is useful when examining cases, but the rest of the time it is a distraction and makes it more difficult to notice problems, so...
Wrapped output to console in test to see if we are in debug mode
Added debug mode indicator to localized javascript data when debug mode is enabled at the server
Added utility routine to check for debug mode to core
Utility routine that checks for debug mode enabled implemented.
Debug mode determined to be enabled when WordPress debug mode is enabled via constant definition
Debug mode determined to be enabled when WPeC debug mode is enabled via constant definition
Debug mode can be enabled/disabled persistently at runtime by a logged in administrative user putting a parameter onto a store url. This will enable WPeC support to enable debug mode via the internet without having to access source code.
Also: added check to
wpsc_element_is_visibleso it doesn't error when called with an undefined element. That call happens when non-standard checkout form field configurations are used.