Skip to content

Commit 564c1f2

Browse files
authored
[wpinet] WebServer: Fix Windows (#7551)
The order of evaluation of parameters is not defined; on Windows, the std::move was executed before the GetBuffer().
1 parent a1b642a commit 564c1f2

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

wpinet/src/main/native/cpp/WebServer.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,10 +163,10 @@ void MyHttpConnection::SendFileResponse(int code, std::string_view codeText,
163163
wpi::raw_uv_ostream os{toSend, 4096};
164164
BuildHeader(os, code, codeText, contentType, (*membuf)->size(), extraHeader);
165165
SendData(os.bufs(), false);
166+
auto buf = (*membuf)->GetBuffer();
166167
m_stream.Write(
167-
{{(*membuf)->GetBuffer()}},
168-
[closeAfter = !m_keepAlive, stream = &m_stream,
169-
membuf = std::shared_ptr{std::move(*membuf)}](auto, uv::Error) {
168+
{{buf}}, [closeAfter = !m_keepAlive, stream = &m_stream,
169+
membuf = std::shared_ptr{std::move(*membuf)}](auto, uv::Error) {
170170
if (closeAfter) {
171171
stream->Close();
172172
}

0 commit comments

Comments
 (0)