Upgrade Maven dependencies (#5553)

The following source code changes were required:

* Whitespace changes from spotless
* PMD warning suppressions for utility class tests
* PMD warning rename from "BeanMembersShouldSerialize" to
  "NonSerializableClass"
* Declared more class members as final

Author: calcmogul

build.gradle

@@ -7,7 +7,7 @@ buildscript {
         }
     }
     dependencies {
-        classpath 'com.hubspot.jinjava:jinjava:2.6.0'
+        classpath 'com.hubspot.jinjava:jinjava:2.7.1'
     }
 }
 
@@ -22,8 +22,8 @@ plugins {
     id 'visual-studio'
     id 'net.ltgt.errorprone' version '3.1.0' apply false
     id 'com.github.johnrengelman.shadow' version '8.1.1' apply false
-    id 'com.diffplug.spotless' version '6.18.0' apply false
-    id 'com.github.spotbugs' version '5.0.14' apply false
+    id 'com.diffplug.spotless' version '6.20.0' apply false
+    id 'com.github.spotbugs' version '5.1.3' apply false
 }
 
 wpilibVersioning.buildServerMode = project.hasProperty('buildServer')

cameraserver/multiCameraServer/build.gradle

@@ -29,7 +29,7 @@ repositories {
 }
 
 dependencies {
-    implementation 'com.google.code.gson:gson:2.8.9'
+    implementation 'com.google.code.gson:gson:2.10.1'
 
     implementation project(':wpiutil')
     implementation project(':wpinet')

cscore/src/main/java/edu/wpi/first/cscore/CameraServerCvJNI.java

@@ -65,6 +65,7 @@ public static native int createCvSource(
   public static native void putSourceFrame(int source, long imageNativeObj);
 
   public static native int createCvSink(String name);
+
   // public static native int createCvSinkCallback(String name,
   //                            void (*processFrame)(long time));
 

fieldImages/build.gradle

@@ -14,9 +14,9 @@ if (!project.hasProperty('onlylinuxathena')) {
     }
 
     dependencies {
-        implementation "com.fasterxml.jackson.core:jackson-annotations:2.12.4"
-        implementation "com.fasterxml.jackson.core:jackson-core:2.12.4"
-        implementation "com.fasterxml.jackson.core:jackson-databind:2.12.4"
+        implementation "com.fasterxml.jackson.core:jackson-annotations:2.15.2"
+        implementation "com.fasterxml.jackson.core:jackson-core:2.15.2"
+        implementation "com.fasterxml.jackson.core:jackson-databind:2.15.2"
     }
 
     ext {

hal/src/main/java/edu/wpi/first/hal/AccumulatorResult.java

@@ -9,6 +9,7 @@
 public class AccumulatorResult {
   /** The total value accumulated. */
   public long value;
+
   /** The number of sample value was accumulated over. */
   public long count;
 

hal/src/main/java/edu/wpi/first/hal/AnalogJNI.java

@@ -3,6 +3,7 @@
 // the WPILib BSD license file in the root directory of this project.
 
 package edu.wpi.first.hal;
+
 /**
  * Analog Input / Output / Accumulator / Trigger JNI Functions.
  *
@@ -19,10 +20,13 @@ public class AnalogJNI extends JNIWrapper {
   public interface AnalogTriggerType {
     /** <i>native declaration : AthenaJava\target\native\include\HAL\Analog.h:54</i> */
     int kInWindow = 0;
+
     /** <i>native declaration : AthenaJava\target\native\include\HAL\Analog.h:55</i> */
     int kState = 1;
+
     /** <i>native declaration : AthenaJava\target\native\include\HAL\Analog.h:56</i> */
     int kRisingPulse = 2;
+
     /** <i>native declaration : AthenaJava\target\native\include\HAL\Analog.h:57</i> */
     int kFallingPulse = 3;
   }
@@ -52,6 +56,7 @@ public interface AnalogTriggerType {
    * @see "HAL_InitializeAnalogOutputPort"
    */
   public static native int initializeAnalogOutputPort(int halPortHandle);
+
   /**
    * Frees an analog output port.
    *
@@ -206,6 +211,7 @@ public interface AnalogTriggerType {
    * @see "HAL_GetAnalogVoltsToValue"
    */
   public static native int getAnalogVoltsToValue(int analogPortHandle, double voltage);
+
   /**
    * Get the analog voltage from a raw value.
    *
@@ -418,6 +424,7 @@ public static native void setAnalogTriggerLimitsDutyCycle(
    */
   public static native void setAnalogTriggerLimitsVoltage(
       int analogTriggerHandle, double lower, double upper);
+
   /**
    * Configures the analog trigger to use the averaged vs. raw values.
    *
@@ -433,6 +440,7 @@ public static native void setAnalogTriggerLimitsVoltage(
    */
   public static native void setAnalogTriggerAveraged(
       int analogTriggerHandle, boolean useAveragedValue);
+
   /**
    * Configures the analog trigger to use a filtered value.
    *

hal/src/main/java/edu/wpi/first/hal/CANData.java

@@ -8,8 +8,10 @@
 public class CANData {
   /** Contents of the CAN frame. */
   public final byte[] data = new byte[8];
+
   /** Length of the frame in bytes. */
   public int length;
+
   /** CAN frame timestamp in milliseconds. */
   public long timestamp;
 

ntcore/src/generate/java/NetworkTableInstance.java.jinja

@@ -553,7 +553,7 @@ public final class NetworkTableInstance implements AutoCloseable {
     }
   }
 
-  private ListenerStorage m_listeners = new ListenerStorage(this);
+  private final ListenerStorage m_listeners = new ListenerStorage(this);
 
   /**
    * Remove a connection listener.

shared/java/javacommon.gradle

@@ -116,9 +116,9 @@ tasks.withType(JavaCompile).configureEach {
 }
 
 dependencies {
-    testImplementation 'org.junit.jupiter:junit-jupiter-api:5.8.2'
-    testImplementation 'org.junit.jupiter:junit-jupiter-params:5.8.2'
-    testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.8.2'
+    testImplementation 'org.junit.jupiter:junit-jupiter-api:5.10.0'
+    testImplementation 'org.junit.jupiter:junit-jupiter-params:5.10.0'
+    testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.10.0'
 
     devImplementation sourceSets.main.output
 }
@@ -132,7 +132,7 @@ task run(type: JavaExec) {
 build.dependsOn devClasses
 
 jacoco {
-    toolVersion = "0.8.8"
+    toolVersion = "0.8.10"
 }
 
 jacocoTestReport {

shared/java/javastyle.gradle

@@ -2,15 +2,15 @@ if (!project.hasProperty('skipJavaFormat')) {
     apply plugin: 'checkstyle'
 
     checkstyle {
-        toolVersion = "10.1"
+        toolVersion = "10.12.2"
         configDirectory = file("${project.rootDir}/styleguide")
         config = resources.text.fromFile(new File(configDirectory.get().getAsFile(), "checkstyle.xml"))
     }
 
     apply plugin: 'pmd'
 
     pmd {
-        toolVersion = '6.44.0'
+        toolVersion = '6.55.0'
         consoleOutput = true
         reportsDir = file("$project.buildDir/reports/pmd")
         ruleSetFiles = files(new File(rootDir, "styleguide/pmd-ruleset.xml"))