Skip to content

Split SendableBuilder's addProperty methods into publish and subscribe methods #5413

Open
@Gold856

Description

@Gold856

Pulled from #5177. If no one else is doing this, I'll make a PR for this. If I do, I have a few questions about implementation:

  1. What are we doing with the addProperty methods? Are we going for full removal (breaking), deprecating for now (full removal later), or just leaving it?
  2. If full removal of addProperty will eventually happen, should I try to keep publishers and subscribers in the same Property object using a Map to find matching keys or something? I tested that, and it wasn't very type-safe.
  3. Along the lines of full removal, should Property be split into Publisher and Subscriber classes? It would be double the allocations, but it would already be double the allocations if 2 didn't work out.

Metadata

Metadata

Assignees

No one assigned

    Labels

    component: wpiutilWPI utility librarytype: choreFormatting, reorganizing, and other necessary (but less impactful) tasks.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions