Add TRAP Instructions, Signed Support, PennSim Testing

.github/workflows/all-tests.yml

@@ -28,6 +28,10 @@ jobs:
     - uses: Swatinem/rust-cache@v2
     - uses: taiki-e/install-action@cargo-llvm-cov
 
+    - uses: awalsh128/cache-apt-pkgs-action@v1
+      with:
+        packages: default-jre
+
     - name: Regular Tests
       run: cargo llvm-cov test --no-report --tests --all-features
 
@@ -70,7 +74,7 @@ jobs:
 
     - uses: awalsh128/cache-apt-pkgs-action@v1
       with:
-        packages: libsodium-dev
+        packages: default-jre
 
     - uses: dtolnay/rust-toolchain@stable
     - uses: Swatinem/rust-cache@v2
@@ -80,31 +84,6 @@ jobs:
         cargo hack --each-feature build --ignore-private
         cargo hack --each-feature test --ignore-private --no-run 
 
-  # From https://github.com/rust-lang/miri
-  miri:
-    runs-on: ubuntu-latest
-    timeout-minutes: 30
-
-    environment:
-      name: ${{ github.ref_name != 'main' && 'testing' || 'unrestricted' }}
-
-    steps:
-      - uses: actions/checkout@v3
-
-      - uses: awalsh128/cache-apt-pkgs-action@v1
-        with:
-          packages: libsodium-dev
-
-      - name: Install Miri
-        run: |
-          rustup toolchain install nightly --component miri
-          rustup override set nightly
-          cargo miri setup
-      - name: Test with Miri
-        run: |
-          MIRIFLAGS="-Zmiri-disable-isolation" \
-            cargo miri test --all-features
-
   # From https://doc.rust-lang.org/cargo/guide/continuous-integration.html#verifying-rust-version
   # See https://crates.io/crates/cargo-hack
   msrv:
@@ -119,13 +98,17 @@ jobs:
 
     - uses: awalsh128/cache-apt-pkgs-action@v1
       with:
-        packages: libsodium-dev
+        packages: |
+          jq
 
     - uses: dtolnay/rust-toolchain@stable
     - uses: Swatinem/rust-cache@v2
     - uses: taiki-e/install-action@cargo-hack
 
-    - run: cargo hack check --version-range 1.79 --all-targets --all-features --ignore-private
+    - name: Test for MSRV in Cargo.toml
+      run: |
+        VERSION="$(cargo metadata --format-version 1 | jq '.packages | .[] | select(.name == "lc3sim")| .rust_version' | tr -d '"')"
+        cargo hack check --version-range "$VERSION" --all-targets --all-features --ignore-private
 
   test:
     strategy:
@@ -154,6 +137,11 @@ jobs:
       with:
         target: ${{ matrix.triple }}
 
+    - uses: awalsh128/cache-apt-pkgs-action@v1
+      if: ${{ matrix.os == 'ubuntu' }}
+      with:
+        packages: default-jre
+
     - uses: Swatinem/rust-cache@v2
 
     - run: cargo test --verbose --all-features

.github/workflows/pages.yml

@@ -64,7 +64,9 @@ jobs:
     - uses: awalsh128/cache-apt-pkgs-action@v1
       with:
         packages: jq \
-          wget
+          wget |
+          default-jre
+
 
     - uses: dtolnay/rust-toolchain@nightly
       with:

Cargo.toml

@@ -1,6 +1,7 @@
 [package]
 name = "lc3sim"
 version = "0.1.1"
+rust-version = "1.82"
 edition = "2021"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
@@ -13,8 +14,23 @@ path = "src/lib.rs"
 name = "lc3sim"
 path = "src/cli.rs"
 
+[[bin]]
+name = "testcli"
+path = "src/testcli.rs"
+
 [dependencies]
 anyhow = "1.0.95"
 once_cell = "1.20.2"
 regex = "1.11.1"
+# To reduce error boilerplate
 thiserror = "2"
+
+[dev-dependencies]
+# To reduce getter boilerplate
+derive-getters = "0.5"
+# More efficient map initialization
+once_map = "0.4"
+# Reducing test writing boilerplate via macro
+paste = "1"
+# Random tempfile names
+uuid = { version = "1", features = ["v4"] }

penn_sim/README.md

@@ -0,0 +1,3 @@
+[PennSim.jar](https://acg.cis.upenn.edu/milom/cse240-Fall06/pennsim/PennSim.jar) and [lc3os.asm](https://acg.cis.upenn.edu/milom/cse240-Fall06/pennsim/code/lc3os.asm) were retrieved on December 29, 2024.
+Both are provided by University of Pennslyvania, presumably by Milo M. K. Martin, for [CSE240](https://acg.cis.upenn.edu/milom/cse240-Fall06/pennsim/pennsim-guide.html).
+The work is presumed to be provided for open source due to its distribution method.