Fix daily build LS job failures and add label-gated LS tests to PR checks#644
Fix daily build LS job failures and add label-gated LS tests to PR checks#644gigara wants to merge 6 commits into
Conversation
- LS Windows build: the longpaths step ran in the job default working directory which does not exist before checkout; run it in the workspace root instead. - LS Ubuntu test: package icon URLs embed the package version, which drifts with the distribution used in CI; normalize the version away when comparing icon fields in AbstractLSTest. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
LS Java test suites previously only ran in the daily build on main, so LS test breakages surfaced post-merge. Adding the 'Checks/Run LS Tests' label to a PR now runs ./gradlew test for the language server, mirroring the e2e test label pattern. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 40 minutes and 53 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The icon URL version normalization in AbstractLSTest only applied to the diff logging; the assertion still used raw JsonObject.equals, so the test kept failing on package version drift with an empty diff. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Deduplicates the LS test setup between the daily build and the label-gated PR check. The daily matrix resolves the action from the matrix.branch checkout, so release branches need this file backported. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 participant
Summary
git config core.longpathsstep ran in the job's default working directory (packages/ballerina-language-server), which does not exist before checkout — Windows fails to start the shell. The step now runs in the workspace root.ArtifactsTestfailures were caused by package icon URLs embedding package versions (e.g.ballerina_tcp_1.13.2.pngvs expected..._1.13.5.png) that drift with the distribution used in CI.AbstractLSTestnow normalizes the version segment away when comparingiconfields.main, so breakages surfaced post-merge. Adding theChecks/Run LS Testslabel to a PR now runs./gradlew testfor the language server, mirroring the existing e2e label pattern.Test plan
Checks/Run LS Testslabel to this PR and confirm the newRun Ballerina LS testsjob runs and passes (verifies theArtifactsTestfix pre-merge)LS Windows buildandLS Ubuntu testjobs pass🤖 Generated with Claude Code