Skip to content

Test Build #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imesh94 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Test Build #878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...org/wso2/financial/services/accelerator/identity/extensions/util/IdentityCommonUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,7 @@ public static boolean isRegulatoryApp(String clientId) throws FinancialServicesE
return Boolean.parseBoolean(regulatoryProperty.toString());
} else {
log.debug("Regulatory property missing. Treating as non-regulatory application.");
log.debug("Test build.");
Copy link

@coderabbitai coderabbitai bot Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove temporary debug statement before merging.

The log statement log.debug("Test build.") provides no diagnostic or contextual value and appears to be leftover test code. Debug logs should convey meaningful information about application state or behavior.

A previous review comment on lines 381-383 already suggested improving the logging in this section by adding an log.info statement that includes the clientId for better traceability. Consider implementing that suggestion instead.

🤖 Prompt for AI Agents 
In
financial-services-accelerator/components/org.wso2.financial/services/accelerator/identity/extensions/src/main/java/org/wso2/financial/services/accelerator/identity/extensions/util/IdentityCommonUtils.java
around line 382, remove the temporary debug statement log.debug("Test build.");
and replace it with a meaningful log call (e.g., log.info or log.debug as
appropriate) that includes the clientId and context to improve traceability;
ensure the message follows existing logging conventions and does not expose
sensitive data.

return false;
Comment on lines 381 to 383
Copy link
Contributor

@wso2-engineering wso2-engineering bot Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log Improvement Suggestion No: 1

Suggested change
log.debug("Regulatory property missing. Treating as non-regulatory application.");
log.debug("Test build.");
return false;
log.debug("Regulatory property missing. Treating as non-regulatory application.");
log.debug("Test build.");
log.info("Client ID: {} treated as non-regulatory application due to missing property", clientId);
return false;

}
} else {
Expand Down