-
Notifications
You must be signed in to change notification settings - Fork 168
Filter duplicate canonical value display labels #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter duplicate canonical value display labels #971
Conversation
...2/carbon/identity/rest/api/server/claim/management/v1/core/ServerClaimManagementService.java
Show resolved
Hide resolved
AI Agent Log Improvement Checklist
✅ Before merging this pull request:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR filters out duplicate canonical value display labels when creating local claims. The change ensures that if multiple canonical values have the same label, only the first occurrence is preserved.
- Replaces direct array-to-JSON conversion with a deduplication process using HashSet and Stream operations
- Uses
Collectors.toMap()with a merge function to handle duplicate labels by keeping the first value
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...2/carbon/identity/rest/api/server/claim/management/v1/core/ServerClaimManagementService.java
Outdated
Show resolved
Hide resolved
...2/carbon/identity/rest/api/server/claim/management/v1/core/ServerClaimManagementService.java
Outdated
Show resolved
Hide resolved
|
PR builder started |
|
PR builder completed |
|
PR builder completed |
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/17131511388
|
Integration tests run in fork |
Purpose
The duplicated canonical values send to the processing will be filtered.
Related Issues