Add improvements related to artifact listing #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
Comment on lines
87
to
89
| public isolated function getServicesByEnvironmentAndComponent(string environmentId, string componentId) returns types:Service[]|error { | ||
| types:Service[] serviceList = []; | ||
| map<boolean> seenHashes = {}; // Track unique service hashes |
There was a problem hiding this comment.
Log Improvement Suggestion No: 1
Suggested change
| public isolated function getServicesByEnvironmentAndComponent(string environmentId, string componentId) returns types:Service[]|error { | |
| types:Service[] serviceList = []; | |
| map<boolean> seenHashes = {}; // Track unique service hashes | |
| public isolated function getServicesByEnvironmentAndComponent(string environmentId, string componentId) returns types:Service[]|error { | |
| log.info(string `Getting services for environment: ${environmentId}, component: ${componentId}`); | |
| types:Service[] serviceList = []; | |
| map<boolean> seenHashes = {}; // Track unique service hashes |
Comment on lines
411
to
413
|
|
||
| sql:ExecutionResult result = check dbClient->execute(` | ||
| sql:ExecutionResult|error insertRes = dbClient->execute(` | ||
| INSERT INTO runtimes ( |
There was a problem hiding this comment.
Log Improvement Suggestion No: 3
Suggested change
| sql:ExecutionResult result = check dbClient->execute(` | |
| sql:ExecutionResult|error insertRes = dbClient->execute(` | |
| INSERT INTO runtimes ( | |
| sql:ExecutionResult|error insertRes = dbClient->execute(` | |
| log:printDebug(string `Attempting to insert runtime ${heartbeat.runtime} with type ${heartbeat.runtimeType}`); | |
| INSERT INTO runtimes ( |
Comment on lines
+434
to
+437
| if insertRes is sql:ExecutionResult { | ||
| int? rows = insertRes.affectedRowCount; | ||
| return rows == 1; | ||
| } |
There was a problem hiding this comment.
Log Improvement Suggestion No: 4
Suggested change
| if insertRes is sql:ExecutionResult { | |
| int? rows = insertRes.affectedRowCount; | |
| return rows == 1; | |
| } | |
| if insertRes is sql:ExecutionResult { | |
| int? rows = insertRes.affectedRowCount; | |
| log:printInfo(string `Successfully inserted runtime ${heartbeat.runtime}`); | |
| return rows == 1; |
| } | ||
|
|
||
| // Get proxy services for a specific runtime | ||
| public isolated function getProxyServicesForRuntime(string runtimeId) returns types:ProxyService[]|error { |
There was a problem hiding this comment.
Log Improvement Suggestion No: 5
Suggested change
| public isolated function getProxyServicesForRuntime(string runtimeId) returns types:ProxyService[]|error { | |
| public isolated function getProxyServicesForRuntime(string runtimeId) returns types:ProxyService[]|error { | |
| log.debug("Fetching proxy services for runtime: " + runtimeId); |
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 | ||
| #### Log Improvement Suggestion No: 3 | ||
| #### Log Improvement Suggestion No: 4 | ||
| #### Log Improvement Suggestion No: 5 |
tharindu-nw
approved these changes
Dec 10, 2025
tharindu-nw
reviewed
Dec 10, 2025
tharindu-nw
approved these changes
Dec 10, 2025
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove wsdl in heartbeat
Add runtimes list for each artifact
Fix db inconsistencies