Add API changes for registry resource support #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
Comment on lines
+601
to
+602
| isolated resource function get registryResourcesByEnvironmentAndComponent(graphql:Context context, string environmentId, string componentId) returns types:RegistryResource[]|error { | ||
| types:UserContextV2 userContext = check extractUserContext(context); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 1
Suggested change
| isolated resource function get registryResourcesByEnvironmentAndComponent(graphql:Context context, string environmentId, string componentId) returns types:RegistryResource[]|error { | |
| types:UserContextV2 userContext = check extractUserContext(context); | |
| isolated resource function get registryResourcesByEnvironmentAndComponent(graphql:Context context, string environmentId, string componentId) returns types:RegistryResource[]|error { | |
| log:printInfo("Fetching registry resources", environmentId = environmentId, componentId = componentId); | |
| types:UserContextV2 userContext = check extractUserContext(context); |
| return []; | ||
| } | ||
|
|
||
| return check storage:getRegistryResourcesByEnvironmentAndComponent(environmentId, componentId); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 2
Suggested change
| return check storage:getRegistryResourcesByEnvironmentAndComponent(environmentId, componentId); | |
| return check storage:getRegistryResourcesByEnvironmentAndComponent(environmentId, componentId); | |
| log:printInfo("Successfully retrieved registry resources", environmentId = environmentId, componentId = componentId); | |
| return check storage:getRegistryResourcesByEnvironmentAndComponent(environmentId, componentId); |
Comment on lines
+629
to
+631
| // Get Registry Resources for a specific environment and component | ||
| public isolated function getRegistryResourcesByEnvironmentAndComponent(string environmentId, string componentId) returns types:RegistryResource[]|error { | ||
| types:RegistryResource[] resourceList = []; |
There was a problem hiding this comment.
Log Improvement Suggestion No: 3
Suggested change
| // Get Registry Resources for a specific environment and component | |
| public isolated function getRegistryResourcesByEnvironmentAndComponent(string environmentId, string componentId) returns types:RegistryResource[]|error { | |
| types:RegistryResource[] resourceList = []; | |
| public isolated function getRegistryResourcesByEnvironmentAndComponent(string environmentId, string componentId) returns types:RegistryResource[]|error { | |
| log:printInfo("Getting registry resources for environment: " + environmentId + " and component: " + componentId); | |
| types:RegistryResource[] resourceList = []; |
Comment on lines
+637
to
+640
| // If no runtimes found, return empty array | ||
| if runtimeIds.length() == 0 { | ||
| return resourceList; | ||
| } |
There was a problem hiding this comment.
Log Improvement Suggestion No: 4
Suggested change
| // If no runtimes found, return empty array | |
| if runtimeIds.length() == 0 { | |
| return resourceList; | |
| } | |
| // If no runtimes found, return empty array | |
| if runtimeIds.length() == 0 { | |
| log:printDebug("No runtimes found for environment: " + environmentId + " and component: " + componentId); | |
| return resourceList; | |
| } |
| `); | ||
| } | ||
|
|
||
| foreach types:RegistryResource registryResource in <types:RegistryResource[]>heartbeat.artifacts.registryResources { |
There was a problem hiding this comment.
Log Improvement Suggestion No: 5
Suggested change
| foreach types:RegistryResource registryResource in <types:RegistryResource[]>heartbeat.artifacts.registryResources { | |
| isolated function insertAdditionalMIArtifacts(types:Heartbeat heartbeat) returns error? { | |
| log:printInfo("Starting to insert additional MI artifacts for runtime: " + heartbeat.runtime); | |
| check insertSecretsToDatabase(dbClient, heartbeat); | |
| check insertServicesToDatabase(dbClient, heartbeat); | |
| check insertHealthStatusToDatabase(dbClient, heartbeat); | |
| check insertRegistryPropertyResourcesToDatabase(dbClient, heartbeat); |
Comment on lines
717
to
718
| foreach types:RegistryResource registryResource in <types:RegistryResource[]>heartbeat.artifacts.registryResources { | ||
| _ = check dbClient->execute(` |
There was a problem hiding this comment.
Log Improvement Suggestion No: 6
Suggested change
| foreach types:RegistryResource registryResource in <types:RegistryResource[]>heartbeat.artifacts.registryResources { | |
| _ = check dbClient->execute(` | |
| foreach types:RegistryResource registryResource in <types:RegistryResource[]>heartbeat.artifacts.registryResources { | |
| if log:isDebugEnabled() { | |
| log:printDebug("Inserting registry resource: " + registryResource.name + " of type: " + registryResource.'type); | |
| } | |
| _ = check dbClient->execute(` |
Comment on lines
558
to
559
| public isolated function getRegistryResourcesForRuntime(string runtimeId) returns types:RegistryResource[]|error { | ||
| types:RegistryResource[] resourceList = []; |
There was a problem hiding this comment.
Log Improvement Suggestion No: 7
Suggested change
| public isolated function getRegistryResourcesForRuntime(string runtimeId) returns types:RegistryResource[]|error { | |
| types:RegistryResource[] resourceList = []; | |
| public isolated function getRegistryResourcesForRuntime(string runtimeId) returns types:RegistryResource[]|error { | |
| log:printInfo("Fetching registry resources for runtime: " + runtimeId); |
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$subject