Skip to content

Conversation

@Dilhasha
Copy link

$subject

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment on lines +1376 to +1387
}

// Build management API base URL
string baseUrl = string `https://${managementHost}`;
if managementPort is string {
baseUrl = string `${baseUrl}:${managementPort}`;
}

log:printInfo("Fetching local entry from runtime management API",
runtimeId = runtime.runtimeId,
managementUrl = baseUrl,
entryName = entryName);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log Improvement Suggestion No: 1

Suggested change
}
// Build management API base URL
string baseUrl = string `https://${managementHost}`;
if managementPort is string {
baseUrl = string `${baseUrl}:${managementPort}`;
}
log:printInfo("Fetching local entry from runtime management API",
runtimeId = runtime.runtimeId,
managementUrl = baseUrl,
entryName = entryName);
// Build management API base URL
string baseUrl = string `https://${managementHost}`;
if managementPort is string {
baseUrl = string `${baseUrl}:${managementPort}`;
}
log:printInfo("Fetching local entry from runtime management API",
runtimeId = runtime.runtimeId,
managementUrl = baseUrl,
entryName = entryName);

Comment on lines +1400 to +1407

// Fetch local entry via ICP Internal API (/icp/artifacts/local-entry)
string artifactPath = string `${ICP_ARTIFACTS_PATH}/local-entry?name=${entryName}`;
log:printDebug("Sending ICP internal API local entry request",
runtimeId = runtime.runtimeId,
managementUrl = baseUrl,
artifactPath = artifactPath,
accept = "application/json"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log Improvement Suggestion No: 2

Suggested change
// Fetch local entry via ICP Internal API (/icp/artifacts/local-entry)
string artifactPath = string `${ICP_ARTIFACTS_PATH}/local-entry?name=${entryName}`;
log:printDebug("Sending ICP internal API local entry request",
runtimeId = runtime.runtimeId,
managementUrl = baseUrl,
artifactPath = artifactPath,
accept = "application/json"
// Fetch local entry via ICP Internal API (/icp/artifacts/local-entry)
string artifactPath = string `${ICP_ARTIFACTS_PATH}/local-entry?name=${entryName}`;
if (log:isDebugEnabled()) {
log:printDebug("Sending ICP internal API local entry request",
runtimeId = runtime.runtimeId,
managementUrl = baseUrl,
artifactPath = artifactPath,
accept = "application/json"
);
}

Copy link

@wso2-engineering wso2-engineering bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Agent Log Improvement Checklist

⚠️ Warning: AI-Generated Review Comments

  • The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
  • Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.

✅ Before merging this pull request:

  • Review all AI-generated comments for accuracy and relevance.
  • Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
Comment Accepted (Y/N) Reason
#### Log Improvement Suggestion No: 1
#### Log Improvement Suggestion No: 2

@Dilhasha Dilhasha changed the title Add API to get local entry value Add API to get local entry value and parameters of Inbound EP Dec 16, 2025
@Dilhasha Dilhasha merged commit 2d62f94 into wso2:icp2 Dec 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants