Add artifacts API improvements #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
Comment on lines
+649
to
+650
| isolated resource function get connectorsByEnvironmentAndComponent(graphql:Context context, string environmentId, string componentId) returns types:Connector[]|error { | ||
| types:UserContextV2 userContext = check extractUserContext(context); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 1
Suggested change
| isolated resource function get connectorsByEnvironmentAndComponent(graphql:Context context, string environmentId, string componentId) returns types:Connector[]|error { | |
| types:UserContextV2 userContext = check extractUserContext(context); | |
| isolated resource function get connectorsByEnvironmentAndComponent(graphql:Context context, string environmentId, string componentId) returns types:Connector[]|error { | |
| log:printInfo("Fetching connectors for component", componentId = componentId, environmentId = environmentId); | |
| types:UserContextV2 userContext = check extractUserContext(context); |
Comment on lines
+667
to
+669
| } | ||
|
|
||
| return check storage:getConnectorsByEnvironmentAndComponent(environmentId, componentId); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 2
Suggested change
| } | |
| return check storage:getConnectorsByEnvironmentAndComponent(environmentId, componentId); | |
| } | |
| log:printInfo("Successfully retrieved connectors", componentId = componentId, environmentId = environmentId, count = check storage:getConnectorsByEnvironmentAndComponent(environmentId, componentId).length()); | |
| return check storage:getConnectorsByEnvironmentAndComponent(environmentId, componentId); |
Comment on lines
+40
to
+42
| isolated function getRuntimeStatusMap(string[] runtimeIds) returns map<string>|error { | ||
| map<string> statusMap = {}; | ||
| if runtimeIds.length() == 0 { |
There was a problem hiding this comment.
Log Improvement Suggestion No: 3
Suggested change
| isolated function getRuntimeStatusMap(string[] runtimeIds) returns map<string>|error { | |
| map<string> statusMap = {}; | |
| if runtimeIds.length() == 0 { | |
| isolated function getRuntimeStatusMap(string[] runtimeIds) returns map<string>|error { | |
| log:printInfo("Fetching runtime status for " + runtimeIds.length().toString() + " runtime IDs"); | |
| map<string> statusMap = {}; |
Comment on lines
+55
to
+56
|
|
||
| sql:ParameterizedQuery query = sql:queryConcat(`SELECT runtime_id, status FROM runtimes WHERE runtime_id IN `, inClause); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 4
Suggested change
| sql:ParameterizedQuery query = sql:queryConcat(`SELECT runtime_id, status FROM runtimes WHERE runtime_id IN `, inClause); | |
| sql:ParameterizedQuery query = sql:queryConcat(`SELECT runtime_id, status FROM runtimes WHERE runtime_id IN `, inClause); | |
| if log:isDebugEnabled() { | |
| log:printDebug("Executing runtime status query for " + runtimeIds.length().toString() + " IDs"); | |
| } | |
| stream<record {|string runtime_id; string status;|}, sql:Error?> rs = dbClient->query(query); |
Comment on lines
628
to
629
| foreach types:Template template in <types:Template[]>heartbeat.artifacts.templates { | ||
| _ = check dbClient->execute(` |
There was a problem hiding this comment.
Log Improvement Suggestion No: 5
Suggested change
| foreach types:Template template in <types:Template[]>heartbeat.artifacts.templates { | |
| _ = check dbClient->execute(` | |
| log:printInfo("Inserting additional MI artifacts for runtime: " + heartbeat.runtime); | |
| foreach types:Template template in <types:Template[]>heartbeat.artifacts.templates { |
Comment on lines
629
to
636
| _ = check dbClient->execute(` | ||
| INSERT INTO runtime_templates ( | ||
| runtime_id, template_name, template_type, state | ||
| runtime_id, template_name, template_type | ||
| ) VALUES ( | ||
| ${heartbeat.runtime}, ${template.name}, ${template.'type}, ${template.state} | ||
| ${heartbeat.runtime}, ${template.name}, ${template.'type} | ||
| ) | ||
| `); | ||
| } |
There was a problem hiding this comment.
Log Improvement Suggestion No: 6
Suggested change
| _ = check dbClient->execute(` | |
| INSERT INTO runtime_templates ( | |
| runtime_id, template_name, template_type, state | |
| runtime_id, template_name, template_type | |
| ) VALUES ( | |
| ${heartbeat.runtime}, ${template.name}, ${template.'type}, ${template.state} | |
| ${heartbeat.runtime}, ${template.name}, ${template.'type} | |
| ) | |
| `); | |
| } | |
| _ = check dbClient->execute(` | |
| INSERT INTO runtime_templates ( | |
| runtime_id, template_name, template_type | |
| ) VALUES ( | |
| ${heartbeat.runtime}, ${template.name}, ${template.'type} | |
| ) | |
| `); | |
| log:printDebug("Inserted template: " + template.name + " of type: " + template.'type + " for runtime: " + heartbeat.runtime); |
Comment on lines
370
to
374
| stream<types:Template, sql:Error?> templateStream = dbClient->query(` | ||
| SELECT template_name, template_type, state | ||
| SELECT template_name, template_type | ||
| FROM runtime_templates | ||
| WHERE runtime_id = ${runtimeId} | ||
| `); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 7
Suggested change
| stream<types:Template, sql:Error?> templateStream = dbClient->query(` | |
| SELECT template_name, template_type, state | |
| SELECT template_name, template_type | |
| FROM runtime_templates | |
| WHERE runtime_id = ${runtimeId} | |
| `); | |
| stream<types:Template, sql:Error?> templateStream = dbClient->query(` | |
| SELECT template_name, template_type | |
| FROM runtime_templates | |
| WHERE runtime_id = ${runtimeId} | |
| `); | |
| log:printInfo("Fetching templates for runtime: " + runtimeId); |
Comment on lines
543
to
547
| stream<types:Connector, sql:Error?> connectorStream = dbClient->query(` | ||
| SELECT connector_name, package as connector_package, version, state | ||
| SELECT connector_name, package, version, state | ||
| FROM runtime_connectors | ||
| WHERE runtime_id = ${runtimeId} | ||
| `); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 8
Suggested change
| stream<types:Connector, sql:Error?> connectorStream = dbClient->query(` | |
| SELECT connector_name, package as connector_package, version, state | |
| SELECT connector_name, package, version, state | |
| FROM runtime_connectors | |
| WHERE runtime_id = ${runtimeId} | |
| `); | |
| stream<types:Connector, sql:Error?> connectorStream = dbClient->query(` | |
| SELECT connector_name, package, version, state | |
| FROM runtime_connectors | |
| WHERE runtime_id = ${runtimeId} | |
| `); | |
| log:printInfo("Fetching connectors for runtime: " + runtimeId); |
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
8 tasks
tharindu-nw
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$subject