NoAdd MODE=MSSQLServer;#27465
Open
Thisara-Welmilla wants to merge 3 commits intowso2:archive_IS-7.3from
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
✅ Files skipped from review due to trivial changes (8)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughConfiguration updates across multiple TOML files to add Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
PR builder started |
Contributor
|
PR builder completed |
Contributor
|
PR builder started |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pom.xml`:
- Line 2739: The pom property identity.event.handler.notification.version is set
to a SNAPSHOT (1.12.11-SNAPSHOT) which can cause build instability; change this
property to a released, fixed version (e.g., 1.12.11 or the latest stable
release) or pin it to a specific non-SNAPSHOT release, update any
dependencyManagement/imports that consume
identity.event.handler.notification.version if needed, and ensure CI and release
notes are adjusted to use the stable version instead of the SNAPSHOT.
- Line 2688: The POM sets carbon.identity.framework.version to a SNAPSHOT
(7.10.137-SNAPSHOT) but this intent isn’t documented; update the PR description
or release notes to state why carbon.identity.framework.version (and any other
SNAPSHOT properties such as the 1.12.11-SNAPSHOT dependency) are pinned to
SNAPSHOT versions for this development/release candidate, and confirm these
values are intentional in the commit message or PR metadata so future
maintainers understand they are temporary development dependencies.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7e03b1f4-4201-4b61-96ad-1ce2d974f42c
📒 Files selected for processing (11)
modules/distribution/src/repository/resources/conf/deployment.tomlmodules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/identityMgt/case_insensitive_user_false.tomlmodules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/organizationDiscovery/email_as_username.tomlmodules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/provisioning/db_separation_config.tomlmodules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/provisioning/default_configs_with_h2_db.tomlmodules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/saml/saml_keystore_rotation.tomlmodules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/scriptEngine/nashorn_script_engine_config.tomlmodules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/scriptEngine/openjdknashorn_script_engine_config.tomlmodules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/userMgt/ldap_user_mgt_config.tomloidc-fapi-conformance-tests/config/deployment-fapi-config.tomlpom.xml
✅ Files skipped from review due to trivial changes (8)
- modules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/organizationDiscovery/email_as_username.toml
- modules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/userMgt/ldap_user_mgt_config.toml
- modules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/saml/saml_keystore_rotation.toml
- modules/distribution/src/repository/resources/conf/deployment.toml
- modules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/identityMgt/case_insensitive_user_false.toml
- modules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/scriptEngine/openjdknashorn_script_engine_config.toml
- modules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/scriptEngine/nashorn_script_engine_config.toml
- modules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/provisioning/default_configs_with_h2_db.toml
🚧 Files skipped from review as they are similar to previous changes (2)
- modules/integration/tests-integration/tests-backend/src/test/resources/artifacts/IS/provisioning/db_separation_config.toml
- oidc-fapi-conformance-tests/config/deployment-fapi-config.toml
| <!--Carbon Identity Framework Version--> | ||
|
|
||
| <carbon.identity.framework.version>7.10.135</carbon.identity.framework.version> | ||
| <carbon.identity.framework.version>7.10.137-SNAPSHOT</carbon.identity.framework.version> |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check if the SNAPSHOT version is available in the WSO2 snapshots repository
echo "Checking WSO2 Maven snapshots repository for carbon.identity.framework 7.10.137-SNAPSHOT..."
curl -s -o /dev/null -w "%{http_code}" "https://maven.wso2.org/nexus/content/repositories/snapshots/org/wso2/carbon/identity/framework/org.wso2.carbon.identity.core/7.10.137-SNAPSHOT/maven-metadata.xml"
echo ""
echo "Checking for latest released version..."
curl -s "https://maven.wso2.org/nexus/content/repositories/releases/org/wso2/carbon/identity/framework/org.wso2.carbon.identity.core/maven-metadata.xml" 2>/dev/null | grep -oP '(?<=<version>)[^<]+' | tail -5Repository: wso2/product-is
Length of output: 194
🏁 Script executed:
#!/bin/bash
# 1. Check how many SNAPSHOT versions exist in pom.xml
echo "=== SNAPSHOT versions in pom.xml ==="
rg "SNAPSHOT" pom.xml | head -20
# 2. Check the context around line 2688
echo ""
echo "=== Context around line 2688 (carbon.identity.framework.version) ==="
sed -n '2680,2695p' pom.xml
# 3. Check if there are any other identity-related versions around line 2739
echo ""
echo "=== Context around line 2739 (identity.event.handler.notification.version) ==="
sed -n '2730,2745p' pom.xml
# 4. Count total SNAPSHOT versions
echo ""
echo "=== Total SNAPSHOT version count ==="
rg "SNAPSHOT" pom.xml | wc -lRepository: wso2/product-is
Length of output: 2307
🏁 Script executed:
#!/bin/bash
# Check git history for the specific version changes
echo "=== Git history for carbon.identity.framework.version ==="
git log --oneline -p pom.xml | grep -A 5 -B 5 "carbon.identity.framework.version" | head -40
# Check recent commits that modified pom.xml
echo ""
echo "=== Recent pom.xml changes ==="
git log --oneline pom.xml | head -10
# Check if current branch is master or a development branch
echo ""
echo "=== Current branch and status ==="
git branch -a | grep -E '^\*|master|main|develop'
git status
# Check if there are any comments or patterns around SNAPSHOT usage
echo ""
echo "=== Check for patterns or comments around SNAPSHOT versions ==="
rg -B 3 -A 1 "SNAPSHOT" pom.xmlRepository: wso2/product-is
Length of output: 3180
🏁 Script executed:
#!/bin/bash
# Get the full commit details including all changes
echo "=== Commit details for 99211d846 ==="
git show 99211d846 --stat
# Look for version history of these specific properties
echo ""
echo "=== Git blame for carbon.identity.framework.version line ==="
git blame pom.xml | grep "carbon.identity.framework.version>" | head -3
# Check if there are any PR descriptions or comments that explain the changes
echo ""
echo "=== Check for any documentation or changelog ==="
ls -la | grep -iE "changelog|changes|release"
</parameter>Repository: wso2/product-is
Length of output: 50497
SNAPSHOT versions are acceptable for SNAPSHOT releases, but document the intent.
The product itself is version 7.3.0-rc1-SNAPSHOT, so using SNAPSHOT dependencies for targeted modules (7.10.137-SNAPSHOT and 1.12.11-SNAPSHOT) is standard practice during development. However, ensure these are intentional and document why these specific dependencies are pinned to SNAPSHOT versions in the PR description or release notes for future maintainability.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pom.xml` at line 2688, The POM sets carbon.identity.framework.version to a
SNAPSHOT (7.10.137-SNAPSHOT) but this intent isn’t documented; update the PR
description or release notes to state why carbon.identity.framework.version (and
any other SNAPSHOT properties such as the 1.12.11-SNAPSHOT dependency) are
pinned to SNAPSHOT versions for this development/release candidate, and confirm
these values are intentional in the commit message or PR metadata so future
maintainers understand they are temporary development dependencies.
Contributor
|
PR builder started |
Contributor
|
PR builder completed |
Thisara-Welmilla
force-pushed
the
TG-stimulation
branch
from
2570407 to
387fa88
Compare
Contributor
|
PR builder started |
|
Contributor
|
PR builder completed |
jenkins-is-staging
approved these changes
Apr 7, 2026
Contributor
jenkins-is-staging
left a comment
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/24094937234
Contributor
|
PR builder completed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit