Skip to content

NoAdd MODE=MSSQLServer; #27465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Thisara-Welmilla wants to merge 3 commits into
base: archive_IS-7.3
Choose a base branch
from
Open

NoAdd MODE=MSSQLServer; #27465

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fad03f4
Add MODE=MSSQLServer;
Thisara-Welmilla Apr 7, 2026
99211d8
Add MODE=MSSQLServer;
Thisara-Welmilla Apr 7, 2026
387fa88
Add COLLATION=en_US;
Thisara-Welmilla Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/distribution/src/repository/resources/conf/deployment.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,19 @@ type = "database_unique_id"

[database.identity_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

[database.shared_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

[datasource.AgentIdentity]
id = "AgentIdentity"
url = "jdbc:h2:./repository/database/WSO2AGENTIDENTITY_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2AGENTIDENTITY_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"
driver = "org.h2.Driver"
Expand Down
4 changes: 2 additions & 2 deletions ...ests-backend/src/test/resources/artifacts/IS/identityMgt/case_insensitive_user_false.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ use_case_sensitive_username_for_cache_keys = "false"

[database.identity_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

[database.shared_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

Expand Down
4 changes: 2 additions & 2 deletions ...ests-backend/src/test/resources/artifacts/IS/organizationDiscovery/email_as_username.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ type = "database_unique_id"

[database.identity_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

[database.shared_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

Expand Down
2 changes: 1 addition & 1 deletion ...tion/tests-backend/src/test/resources/artifacts/IS/provisioning/db_separation_config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ password = "wso2carbon"

[datasource.CONSENT_DB]
id = "CONSENT_DB"
url = "jdbc:h2:./repository/database/CONSENT_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/CONSENT_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"
driver = "org.h2.Driver"
Expand Down
6 changes: 3 additions & 3 deletions ...ests-backend/src/test/resources/artifacts/IS/provisioning/default_configs_with_h2_db.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,19 @@ type = "database_unique_id"

[database.identity_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

[database.shared_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

[datasource.AgentIdentity]
id = "AgentIdentity"
url = "jdbc:h2:./repository/database/WSO2AGENTIDENTITY_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2AGENTIDENTITY_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"
driver = "org.h2.Driver"
Expand Down
6 changes: 3 additions & 3 deletions ...ntegration/tests-backend/src/test/resources/artifacts/IS/saml/saml_keystore_rotation.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,19 @@ type = "database_unique_id"

[database.identity_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

[database.shared_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

[datasource.AgentIdentity]
id = "AgentIdentity"
url = "jdbc:h2:./repository/database/WSO2AGENTIDENTITY_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2AGENTIDENTITY_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"
driver = "org.h2.Driver"
Expand Down
4 changes: 2 additions & 2 deletions ...ts-backend/src/test/resources/artifacts/IS/scriptEngine/nashorn_script_engine_config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ type = "database_unique_id"

[database.identity_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

[database.shared_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

Expand Down
4 changes: 2 additions & 2 deletions ...end/src/test/resources/artifacts/IS/scriptEngine/openjdknashorn_script_engine_config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ type = "database_unique_id"

[database.identity_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

[database.shared_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

Expand Down
4 changes: 2 additions & 2 deletions ...tegration/tests-backend/src/test/resources/artifacts/IS/userMgt/ldap_user_mgt_config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ base_dn = "dc=wso2,dc=org"

[database.identity_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

[database.shared_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

Expand Down
6 changes: 3 additions & 3 deletions oidc-fapi-conformance-tests/config/deployment-fapi-config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,19 @@ type = "database_unique_id"

[database.identity_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2IDENTITY_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

[database.shared_db]
type = "h2"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2SHARED_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"

[datasource.AgentIdentity]
id = "AgentIdentity"
url = "jdbc:h2:./repository/database/WSO2AGENTIDENTITY_DB;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
url = "jdbc:h2:./repository/database/WSO2AGENTIDENTITY_DB;IGNORECASE=TRUE;DB_CLOSE_ON_EXIT=FALSE;LOCK_TIMEOUT=60000"
username = "wso2carbon"
password = "wso2carbon"
driver = "org.h2.Driver"
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2685,7 +2685,7 @@

<!--Carbon Identity Framework Version-->

<carbon.identity.framework.version>7.10.135</carbon.identity.framework.version>
<carbon.identity.framework.version>7.10.137-SNAPSHOT</carbon.identity.framework.version>
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Check if the SNAPSHOT version is available in the WSO2 snapshots repository

echo "Checking WSO2 Maven snapshots repository for carbon.identity.framework 7.10.137-SNAPSHOT..."
curl -s -o /dev/null -w "%{http_code}" "https://maven.wso2.org/nexus/content/repositories/snapshots/org/wso2/carbon/identity/framework/org.wso2.carbon.identity.core/7.10.137-SNAPSHOT/maven-metadata.xml"
echo ""

echo "Checking for latest released version..."
curl -s "https://maven.wso2.org/nexus/content/repositories/releases/org/wso2/carbon/identity/framework/org.wso2.carbon.identity.core/maven-metadata.xml" 2>/dev/null | grep -oP '(?<=<version>)[^<]+' | tail -5

Repository: wso2/product-is

Length of output: 194

🏁 Script executed:

#!/bin/bash

# 1. Check how many SNAPSHOT versions exist in pom.xml
echo "=== SNAPSHOT versions in pom.xml ==="
rg "SNAPSHOT" pom.xml | head -20

# 2. Check the context around line 2688
echo ""
echo "=== Context around line 2688 (carbon.identity.framework.version) ==="
sed -n '2680,2695p' pom.xml

# 3. Check if there are any other identity-related versions around line 2739
echo ""
echo "=== Context around line 2739 (identity.event.handler.notification.version) ==="
sed -n '2730,2745p' pom.xml

# 4. Count total SNAPSHOT versions
echo ""
echo "=== Total SNAPSHOT version count ==="
rg "SNAPSHOT" pom.xml | wc -l

Repository: wso2/product-is

Length of output: 2307

🏁 Script executed:

#!/bin/bash

# Check git history for the specific version changes
echo "=== Git history for carbon.identity.framework.version ==="
git log --oneline -p pom.xml | grep -A 5 -B 5 "carbon.identity.framework.version" | head -40

# Check recent commits that modified pom.xml
echo ""
echo "=== Recent pom.xml changes ==="
git log --oneline pom.xml | head -10

# Check if current branch is master or a development branch
echo ""
echo "=== Current branch and status ==="
git branch -a | grep -E '^\*|master|main|develop'
git status

# Check if there are any comments or patterns around SNAPSHOT usage
echo ""
echo "=== Check for patterns or comments around SNAPSHOT versions ==="
rg -B 3 -A 1 "SNAPSHOT" pom.xml

Repository: wso2/product-is

Length of output: 3180

🏁 Script executed:

#!/bin/bash

# Get the full commit details including all changes
echo "=== Commit details for 99211d846 ==="
git show 99211d846 --stat

# Look for version history of these specific properties
echo ""
echo "=== Git blame for carbon.identity.framework.version line ==="
git blame pom.xml | grep "carbon.identity.framework.version>" | head -3

# Check if there are any PR descriptions or comments that explain the changes
echo ""
echo "=== Check for any documentation or changelog ==="
ls -la | grep -iE "changelog|changes|release"
</parameter>

Repository: wso2/product-is

Length of output: 50497

SNAPSHOT versions are acceptable for SNAPSHOT releases, but document the intent.

The product itself is version 7.3.0-rc1-SNAPSHOT, so using SNAPSHOT dependencies for targeted modules (7.10.137-SNAPSHOT and 1.12.11-SNAPSHOT) is standard practice during development. However, ensure these are intentional and document why these specific dependencies are pinned to SNAPSHOT versions in the PR description or release notes for future maintainability.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@pom.xml` at line 2688, The POM sets carbon.identity.framework.version to a
SNAPSHOT (7.10.137-SNAPSHOT) but this intent isn’t documented; update the PR
description or release notes to state why carbon.identity.framework.version (and
any other SNAPSHOT properties such as the 1.12.11-SNAPSHOT dependency) are
pinned to SNAPSHOT versions for this development/release candidate, and confirm
these values are intentional in the commit message or PR metadata so future
maintainers understand they are temporary development dependencies.


<carbon.identity.framework.version.range>[5.14.67, 8.0.0)</carbon.identity.framework.version.range>

Expand Down Expand Up @@ -2736,7 +2736,7 @@

<!-- Identity Event Handler Versions -->
<identity.event.handler.account.lock.version>1.12.0</identity.event.handler.account.lock.version>
<identity.event.handler.notification.version>1.12.10</identity.event.handler.notification.version>
<identity.event.handler.notification.version>1.12.11-SNAPSHOT</identity.event.handler.notification.version>
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

<org.wso2.identity.webhook.event.handlers.version>1.2.3</org.wso2.identity.webhook.event.handlers.version>
<org.wso2.identity.event.publishers.version>1.2.2</org.wso2.identity.event.publishers.version>
Expand Down