Skip to content

Conversation

@xerial-bot
Copy link
Collaborator

About this PR

📦 Updates com.google.protobuf:protobuf-java from 3.25.8 to 4.33.4

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.google.protobuf", artifactId = "protobuf-java" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.protobuf", artifactId = "protobuf-java" }
}]
labels: library-update

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a routine maintenance task: updating the protobuf-java library to its latest stable version. This ensures the project benefits from the most recent features, performance improvements, and security fixes provided by the Protocol Buffers Java implementation. The change is confined to the build configuration, reflecting a straightforward dependency bump.

Highlights

  • Dependency Update: The protobuf-java dependency has been updated from version 3.25.8 to 4.33.4.
  • Automated Process: This update was automatically generated by Scala Steward, a tool for keeping Scala project dependencies up-to-date.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, managed by Scala Steward, proposes an update for protobuf-java from version 3.25.8 to 4.33.4. This constitutes a major version upgrade, which is likely to introduce significant breaking changes. My primary concern, as detailed in the specific comment, is the potential incompatibility between the new library version and the existing, pre-generated Protobuf Java source files. These files must be regenerated using a compatible version of the protoc compiler to ensure the project remains stable and functional. Without this step, there is a high risk of build failures or runtime errors.

// For grpc-java
"io.grpc" % "grpc-protobuf" % GRPC_VERSION,
"com.google.protobuf" % "protobuf-java" % "3.25.8",
"com.google.protobuf" % "protobuf-java" % "4.33.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update to protobuf-java from a 3.x to a 4.x version is a major upgrade and likely includes breaking API changes. The airframe-benchmark module contains pre-generated Java source files (e.g., HelloRequest.java, HelloReply.java) which were created with an older version of the protoc compiler. These files are probably incompatible with the new protobuf-java runtime.

To avoid compilation errors or runtime issues such as NoSuchMethodError, it is crucial to regenerate these files using a version of protoc that is compatible with protobuf-java:4.33.4. Please ensure the generated sources are updated as part of this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants