Skip to content

Refactored customtreecontrol and hypertreelist from PR#2088 #2734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HelioGuilherme66
Copy link
Contributor

This is the updated files from https://github.com/cbeytas/Phoenix

Fixes PR#2088

Note: This need careful review!

@RobinD42
Copy link
Member

This pull request has been mentioned on Discuss wxPython. There might be relevant details there:

https://discuss.wxpython.org/t/customtreecontrol-escaping-edit-node-label-causes-inconsistent-state-on-linux/40200/6

@echoix
Copy link
Contributor

echoix commented Apr 17, 2025

Is it possible to untangle the formatting changes to make it reviewable? Either a separate commit if absolutely needed, or a different PR. I tried taking a look, GitHub's mobile UI doesn't want to load it. And scrolled a bit and didn't get to a real change yet

@swt2c
Copy link
Collaborator

swt2c commented Apr 17, 2025

Is it possible to untangle the formatting changes to make it reviewable? Either a separate commit if absolutely needed, or a different PR. I tried taking a look, GitHub's mobile UI doesn't want to load it. And scrolled a bit and didn't get to a real change yet

Agreed. That's one of the main reasons I haven't gotten through reviewing the original PR - a massive change, with formatting changes mixed in with functional changes...

@echoix
Copy link
Contributor

echoix commented Apr 17, 2025

If there's also other improvements that aren't related to the fix needed for your issue, and the changes can live without, it might be a good idea to not include them here too.

These are mitigation ways to help out have a PR reviewed, especially since it was stalled for years because of the difficulty of reviewing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants