xapi_vm_clone: Remove impossible, confusing case when dealing with suspend VDIs #6704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spend VDIs This case was impossible because 2 reasons: 1. the polymorphic variant `Runnning used had a typo 2. the reference for the suspend VDI is only present when the VM is suspended, and otherwise is Ref.null. This means that when the VM is running, the code takes the then branch before this one. I didn't see any code dealing with shared suspend images, so I'd rather not have to avoid making the clone and deal with the shared situation. Signed-off-by: Pau Ruiz Safont <[email protected]>
edwintorok
approved these changes
Oct 10, 2025
minglumlu
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This case was impossible due to 2 reasons:
I didn't see any code dealing with shared suspend images, so I'd rather avoid making the clone and deal with the shared situation.