Skip to content

xapi_vm_clone: Remove impossible, confusing case when dealing with suspend VDIs #6704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

xapi_vm_clone: Remove impossible, confusing case when dealing with suspend VDIs #6704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ocaml/xapi/xapi_vm_clone.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,9 +507,6 @@ let clone ?snapshot_info_record ?(ignore_vdis = []) disk_op ~__context ~vm
let original = Db.VM.get_suspend_VDI ~__context ~self:vm in
if original = Ref.null || disk_op = Disk_op_snapshot then
Ref.null
else if disk_op = Disk_op_checkpoint && power_state = `Runnning
then
original
else
clone_single_vdi rpc session_id disk_op ~__context original
driver_params
Expand Down
Loading