Maintenance: Use class extensions where appropriate#1428
Maintenance: Use class extensions where appropriate#1428wutschel wants to merge 13 commits intoxbmc:masterfrom
Conversation
ceb8bd8 to
63f3c85
Compare
63f3c85 to
f91d617
Compare
b846f7a to
0ab27d2
Compare
0ab27d2 to
401e303
Compare
401e303 to
ba85a35
Compare
|
@kambala-decapitator, I would like to get this one in once the open PRs got merged. Following the latest approach to introduce extensions, I will migrate this PR to also introduce dedicated / reuse existing extension files. This would cause merge conflicts with the current open PRs, so I will wait. But you might want to have at this one already. |
16568c4 to
cd9e5c9
Compare
|
Resolved the conflict. When you're generally fine with this, I will squash most of it into 1 commit per class extension and move the extension into dedicated .h/.m files, following the way it was recently done for the other changes. |
|
please fix build |
Fixed, was not seeing this locally as this PR needed another rebase. Good to redo the extension now? |
|
This was quite some nasty work. Now squashed commits into a single commit per class extension and reworked the whole implementation to use dedicated files for the class extensions. This added quite some changes to the xcode project file and many new imports to other classes. |
|
Found another bug in the actors table and migrated few more frame changes to the newly introduced extensions. Reviewed this twice now after the final changes, should be good if you also agree. In this case, I would do a final squashing. |
Like I said before, you could add extension imports to the pch |
Let me try that. I was only thinking of adding the extensions themselves to the pch and dropped it. |
Prepares moving rounded corner implementations for UIImageView and UIImage into separate class extensions.
The parameters reflect the image color for light mode and dark mode.
Convert playcount into BOOL and use this to set visibility.
|
Here we go, looks cleaner to me, also added commit to include the other extensions via the pch. |
Description
Closes #1350.
This PR reworks the
Utilitiesclass and introduces several extensions forUILabel,UIView,UIImageView,UIColor,UIImageandNSString. Some existing extensions were moved there as well, and the dedicated files for these extension got removed (image resizing and SHA256 methods).Summary for release notes
Maintenance: Use class extensions where appropriate