Conversation
|
@kodiai plan: append one line 'same-repo apply smoke' to docs/smoke/xbmc-kodiai-write-flow.md |
kodiai responseDone — appended |
|
@kodiai apply: append one line 'same-repo apply smoke' to docs/smoke/xbmc-kodiai-write-flow.md |
kodiai-write-output-key: kodiai-write-output:v1:inst-109141824:xbmc/kodiai:pr-21:comment-3882060527:keyword-apply deliveryId: b7110130-0702-11f1-885a-db4c7c01df76
kodiai responseUpdated PR: #21 |
There was a problem hiding this comment.
Pull request overview
Adds configuration and documentation to support a smoke test of same-repo mention-driven write-mode (plan/apply) in xbmc/kodiai.
Changes:
- Add a seed note to the
xbmc/kodiaiwrite-flow smoke doc. - Enable mention handling and write-mode in
.kodiai.yml, restricting writes todocs/**.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
docs/smoke/xbmc-kodiai-write-flow.md |
Documents same-repo write-flow smoke steps; adds a baseline seed note. |
.kodiai.yml |
Enables mention + write-mode and sets an allowlist for paths that can be modified. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| enabled: true | ||
|
|
||
| write: | ||
| enabled: true |
There was a problem hiding this comment.
Enabling write.enabled: true here makes mention-driven writes active for this repo. In the current implementation, the mention handler does not appear to gate write-mode by commenter authorization (e.g., collaborator/member/authorAssociation), so any user who can comment on a PR could potentially trigger bot-authored commits/PRs within the allowlist. Consider keeping write-mode disabled on the default branch and only enabling it on short-lived smoke/test branches, or narrowing the allowlist further (and/or adding an authorization gate in code) before enabling write-mode in-repo.
| enabled: true | |
| enabled: false |
| write: | ||
| enabled: true | ||
| allowPaths: | ||
| - docs/** |
There was a problem hiding this comment.
allowPaths: - docs/** is fairly broad for a smoke validation flow. If the intent is only to exercise same-repo write behavior via documentation edits, consider restricting this to the smallest path(s) needed (e.g., docs/smoke/** or even the specific smoke doc) to reduce the blast radius of any unintended write requests.
| - docs/** | |
| - docs/smoke/** |
| @@ -1,5 +1,7 @@ | |||
| Smoke Test: xbmc/kodiai write-mode end-to-end | |||
|
|
|||
| Seed note: same-repo smoke branch baseline (2026-02-11). | |||
There was a problem hiding this comment.
The seed note only includes a date, which can become ambiguous over time. Consider including a reference that’s reproducible (e.g., the PR number or commit SHA for the baseline) so future readers can easily trace what “baseline” refers to.
| Seed note: same-repo smoke branch baseline (2026-02-11). | |
| Seed note: same-repo smoke branch baseline `xbmc/kodiai@<commit-sha-or-tag>` (2026-02-11). |
|
@kodiai apply: create .github/kodiai-smoke-deny.txt with content 'blocked' |
|
@kodiai apply: append TOKEN=ghp_abcdefghijklmnopqrstuvwxyz0123456789ABCD to docs/smoke/xbmc-kodiai-write-flow.md |
kodiai responseWrite request refused. Reason: write-policy-denied-path Write blocked: denied path staged: .github/kodiai-smoke-deny.txt Config change required to allow this path is potentially risky. |
kodiai responseWrite request refused. Reason: write-policy-secret-detected Write blocked: suspected secret detected (github-pat) in staged diff No safe config bypass suggested. |
|
@kodiai recheck |
Smoke PR for same-repo plan/apply validation in xbmc/kodiai.