Skip to content

smoke: same-repo write flow validation #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keithah wants to merge 2 commits into from
Closed

smoke: same-repo write flow validation #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b24b77c
test(smoke): setup same-repo write-mode validation
keithah Feb 11, 2026
7469bb3
kodiai: apply requested changes (pr #21)
kodiai[bot] Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .kodiai.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
review:
uiRereviewTeam: aireview
requestUiRereviewTeamOnOpen: true

mention:
enabled: true

write:
enabled: true
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling write.enabled: true here makes mention-driven writes active for this repo. In the current implementation, the mention handler does not appear to gate write-mode by commenter authorization (e.g., collaborator/member/authorAssociation), so any user who can comment on a PR could potentially trigger bot-authored commits/PRs within the allowlist. Consider keeping write-mode disabled on the default branch and only enabling it on short-lived smoke/test branches, or narrowing the allowlist further (and/or adding an authorization gate in code) before enabling write-mode in-repo.

Suggested change
enabled: true
enabled: false

Copilot uses AI. Check for mistakes.
allowPaths:
- docs/**
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowPaths: - docs/** is fairly broad for a smoke validation flow. If the intent is only to exercise same-repo write behavior via documentation edits, consider restricting this to the smallest path(s) needed (e.g., docs/smoke/** or even the specific smoke doc) to reduce the blast radius of any unintended write requests.

Suggested change
- docs/**
- docs/smoke/**

Copilot uses AI. Check for mistakes.
4 changes: 4 additions & 0 deletions docs/smoke/xbmc-kodiai-write-flow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
Smoke Test: xbmc/kodiai write-mode end-to-end

Seed note: same-repo smoke branch baseline (2026-02-11).
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The seed note only includes a date, which can become ambiguous over time. Consider including a reference that’s reproducible (e.g., the PR number or commit SHA for the baseline) so future readers can easily trace what “baseline” refers to.

Suggested change
Seed note: same-repo smoke branch baseline (2026-02-11).
Seed note: same-repo smoke branch baseline `xbmc/kodiai@<commit-sha-or-tag>` (2026-02-11).

Copilot uses AI. Check for mistakes.

Goal

Validate the full mention-driven write flow in the default repo (`xbmc/kodiai`) using:
Expand Down Expand Up @@ -123,3 +125,5 @@ Only run the same smoke steps in `xbmc/xbmc` if the behavior depends on:
- repo size/perf (timeouts, clone strategy)
- permissions unique to xbmc/xbmc
- configs that differ materially from xbmc/kodiai

same-repo apply smoke