Use vm.detect_package_manager() to check if apk is available - #540
Merged
Conversation
olivierh-pro
approved these changes
May 20, 2026
Wescoeur
reviewed
May 20, 2026
Comment on lines
503
to
508
| elif self.file_exists('/usr/bin/apt-get'): | ||
| return PackageManagerEnum.APT_GET | ||
| elif self.file_exists('/sbin/apk'): | ||
| return PackageManagerEnum.APK | ||
| else: | ||
| return PackageManagerEnum.UNKNOWN |
Member
There was a problem hiding this comment.
Suggested change
| elif self.file_exists('/usr/bin/apt-get'): | |
| return PackageManagerEnum.APT_GET | |
| elif self.file_exists('/sbin/apk'): | |
| return PackageManagerEnum.APK | |
| else: | |
| return PackageManagerEnum.UNKNOWN | |
| if self.file_exists('/usr/bin/apt-get'): | |
| return PackageManagerEnum.APT_GET | |
| if self.file_exists('/sbin/apk'): | |
| return PackageManagerEnum.APK | |
| return PackageManagerEnum.UNKNOWN |
Member
Author
There was a problem hiding this comment.
One line shorter, I like it :)
Done.
glehmann
force-pushed
the
gln/detect-package-manager-apk-zysx
branch
from
May 20, 2026 14:46
e268077 to
757ef63
Compare
glehmann
force-pushed
the
gln/detect-package-manager-apk-zysx
branch
from
May 20, 2026 14:47
757ef63 to
eef0398
Compare
ydirson
reviewed
May 20, 2026
glehmann
force-pushed
the
gln/detect-package-manager-apk-zysx
branch
3 times, most recently
from
May 22, 2026 15:29
c643b60 to
6738a0e
Compare
glehmann
force-pushed
the
gln/detect-package-manager-apk-zysx
branch
2 times, most recently
from
June 4, 2026 20:29
0b91aaa to
022f4bf
Compare
glehmann
force-pushed
the
gln/detect-package-manager-apk-zysx
branch
from
June 8, 2026 09:43
022f4bf to
a10e49e
Compare
Wescoeur
approved these changes
Jun 9, 2026
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/detect-package-manager-apk-zysx
branch
from
June 10, 2026 08:57
a10e49e to
972c6af
Compare
Member
Author
|
Test image: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 2 PRs:
master