Skip to content

Use vm.detect_package_manager() to check if apk is available - #540

Merged
glehmann merged 1 commit into
masterfrom
gln/detect-package-manager-apk-zysx
Jun 10, 2026
Merged

Use vm.detect_package_manager() to check if apk is available#540
glehmann merged 1 commit into
masterfrom
gln/detect-package-manager-apk-zysx

Conversation

@glehmann

@glehmann glehmann commented May 20, 2026

Copy link
Copy Markdown
Member

This PR is part of a stack containing 2 PRs:

  1. master
  2. "Use vm.detect_package_manager() to check if apk is available" (this PR)
  3. Move root partition resizing logic to VM.grow_root_partition() #542

@glehmann
glehmann requested review from a team as code owners May 20, 2026 07:40
@olivierh-pro
olivierh-pro requested a review from a team May 20, 2026 09:19
@glehmann glehmann changed the title use vm.detect_package_manager() to check if apk is available Use vm.detect_package_manager() to check if apk is available May 20, 2026
Comment thread lib/vm.py Outdated
Comment on lines 503 to 508
elif self.file_exists('/usr/bin/apt-get'):
return PackageManagerEnum.APT_GET
elif self.file_exists('/sbin/apk'):
return PackageManagerEnum.APK
else:
return PackageManagerEnum.UNKNOWN

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elif self.file_exists('/usr/bin/apt-get'):
return PackageManagerEnum.APT_GET
elif self.file_exists('/sbin/apk'):
return PackageManagerEnum.APK
else:
return PackageManagerEnum.UNKNOWN
if self.file_exists('/usr/bin/apt-get'):
return PackageManagerEnum.APT_GET
if self.file_exists('/sbin/apk'):
return PackageManagerEnum.APK
return PackageManagerEnum.UNKNOWN

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line shorter, I like it :)
Done.

@glehmann
glehmann force-pushed the gln/detect-package-manager-apk-zysx branch from e268077 to 757ef63 Compare May 20, 2026 14:46
@glehmann glehmann changed the title Use vm.detect_package_manager() to check if apk is available use vm.detect_package_manager() to check if apk is available May 20, 2026
@glehmann
glehmann force-pushed the gln/detect-package-manager-apk-zysx branch from 757ef63 to eef0398 Compare May 20, 2026 14:47
@glehmann glehmann changed the title use vm.detect_package_manager() to check if apk is available Use vm.detect_package_manager() to check if apk is available May 20, 2026
Comment thread lib/vm.py
@glehmann
glehmann force-pushed the gln/detect-package-manager-apk-zysx branch 3 times, most recently from c643b60 to 6738a0e Compare May 22, 2026 15:29
@glehmann
glehmann requested a review from Wescoeur May 22, 2026 17:39
@glehmann
glehmann force-pushed the gln/detect-package-manager-apk-zysx branch 2 times, most recently from 0b91aaa to 022f4bf Compare June 4, 2026 20:29
@glehmann
glehmann force-pushed the gln/detect-package-manager-apk-zysx branch from 022f4bf to a10e49e Compare June 8, 2026 09:43
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
glehmann force-pushed the gln/detect-package-manager-apk-zysx branch from a10e49e to 972c6af Compare June 10, 2026 08:57
@glehmann
glehmann merged commit 9562dda into master Jun 10, 2026
11 checks passed
@glehmann
glehmann deleted the gln/detect-package-manager-apk-zysx branch June 10, 2026 09:05
@glehmann

glehmann commented Jul 5, 2026

Copy link
Copy Markdown
Member Author

Test image:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants