Move root partition resizing logic to VM.grow_root_partition() - #542
Merged
Conversation
glehmann
force-pushed
the
gln/detect-package-manager-apk-zysx
branch
from
May 20, 2026 14:47
757ef63 to
eef0398
Compare
glehmann
force-pushed
the
gln/refactor-root-partition-resizing-vyxq
branch
3 times, most recently
from
May 20, 2026 14:50
58bac05 to
e5d048c
Compare
ydirson
reviewed
May 20, 2026
ydirson
left a comment
ydirson
left a comment
Collaborator
There was a problem hiding this comment.
It would be good to add more context, not everyone is expected to know what this partition resizing is about
ydirson
reviewed
May 20, 2026
Comment on lines
+513
to
+519
| # growpart is not available in alpine 3.12 | ||
| # vm.ssh('apk add cloud-utils-growpart e2fsprogs-extra') | ||
| self.ssh('apk add gawk util-linux e2fsprogs-extra') | ||
| self.ssh( | ||
| 'wget https://raw.githubusercontent.com/canonical/cloud-utils/main/bin/growpart -O /usr/bin/growpart' | ||
| ) | ||
| self.ssh('chmod +x /usr/bin/growpart') |
Collaborator
There was a problem hiding this comment.
This still gives an external dependency on known-flaky github, I'm not sure we want to have more of them.
Is there any particular reason to use such an external tool? Wouldn't parted just avoid this?
Member
Author
There was a problem hiding this comment.
It doesn't add a dependency, it's already there.
Member
Author
There was a problem hiding this comment.
I removed growpart and used sfdisk and partx instead, which were already dependencies
glehmann
force-pushed
the
gln/detect-package-manager-apk-zysx
branch
from
May 20, 2026 19:02
eef0398 to
2b44b30
Compare
glehmann
force-pushed
the
gln/refactor-root-partition-resizing-vyxq
branch
from
May 20, 2026 19:02
e5d048c to
2dfde42
Compare
glehmann
force-pushed
the
gln/detect-package-manager-apk-zysx
branch
from
May 21, 2026 21:29
2b44b30 to
c643b60
Compare
glehmann
force-pushed
the
gln/refactor-root-partition-resizing-vyxq
branch
4 times, most recently
from
May 22, 2026 15:29
a6d89bc to
bd9fc0e
Compare
glehmann
force-pushed
the
gln/detect-package-manager-apk-zysx
branch
from
May 22, 2026 15:29
c643b60 to
6738a0e
Compare
glehmann
force-pushed
the
gln/refactor-root-partition-resizing-vyxq
branch
from
May 29, 2026 11:37
bd9fc0e to
227d3fc
Compare
glehmann
force-pushed
the
gln/detect-package-manager-apk-zysx
branch
from
May 29, 2026 11:37
6738a0e to
0b91aaa
Compare
glehmann
force-pushed
the
gln/refactor-root-partition-resizing-vyxq
branch
from
June 4, 2026 20:29
227d3fc to
23beb66
Compare
glehmann
force-pushed
the
gln/detect-package-manager-apk-zysx
branch
2 times, most recently
from
June 8, 2026 09:43
022f4bf to
a10e49e
Compare
glehmann
force-pushed
the
gln/refactor-root-partition-resizing-vyxq
branch
2 times, most recently
from
June 10, 2026 08:57
13c905d to
96153b6
Compare
glehmann
force-pushed
the
gln/detect-package-manager-apk-zysx
branch
from
June 10, 2026 08:57
a10e49e to
972c6af
Compare
olivierh-pro
approved these changes
Jun 23, 2026
Millefeuille42
requested changes
Jul 7, 2026
glehmann
force-pushed
the
gln/refactor-root-partition-resizing-vyxq
branch
3 times, most recently
from
July 7, 2026 16:59
30750b4 to
d87c336
Compare
Millefeuille42
approved these changes
Jul 8, 2026
Millefeuille42
left a comment
Millefeuille42
left a comment
Contributor
There was a problem hiding this comment.
The two of my remaining comments aren't blocking, but must be resolved either way (applying the suggestion or not) before merging.
AnthoineB
approved these changes
Jul 9, 2026
And make it a bit more robust, by: - fetching the actual partition mounted on / - checking if the filesystem is ext* Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
github is not exactly reliable these days. use sfdisk, which is also used by growpart internally Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
and implement missing command for opensuse Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/refactor-root-partition-resizing-vyxq
branch
from
July 28, 2026 15:16
d87c336 to
686b749
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And make it a bit more robust, by fetching the actual partition mounted on
/Also add support for other Linux distributions than Alpine.
Signed-off-by: Gaëtan Lehmann gaetan.lehmann@vates.tech
This PR is part of a stack containing 2 PRs:
master