Skip to content

[pending feature merge] Create tests for vdi_revert on linstorsr #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
klmp200 wants to merge 2 commits into
base: vdi_revert_lvm
Choose a base branch
from
Open

[pending feature merge] Create tests for vdi_revert on linstorsr #632

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72c2994
Create tests for vdi_revert on linstorsr
klmp200 Jul 17, 2026
420df50
Add `linstor_no_monitor` fixture
klmp200 Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion tests/storage/linstor/test_linstor_sr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@
import time

from lib.commands import SSHCommandFailed
from lib.common import safe_split, vm_image, wait_for
from lib.common import Defer, safe_split, vm_image, wait_for
from lib.host import Host
from lib.pool import Pool
from lib.sr import SR
from lib.vdi import VDI
from lib.vm import VM
from tests.storage import vdi_is_open
from tests.storage.storage import check_critical_journal_revert, check_vdi_revert, check_vdi_revert_journal

from .conftest import GROUP_NAME, LINSTOR_PACKAGE

Expand Down Expand Up @@ -189,6 +190,37 @@ def test_resynchronization(
finally:
vm.shutdown(verify=True)

@pytest.mark.small_vm
@pytest.mark.big_vm
def test_revert(self, vm_on_linstor_sr: VM, defer: Defer) -> None:
check_vdi_revert(defer, vm_on_linstor_sr)

@pytest.mark.small_vm
@pytest.mark.big_vm
@pytest.mark.parametrize(
"fistpoint",
[
"LinstorSR_revert_create_insert",
"LinstorSR_revert_create_src",
"LinstorSR_revert_create_dest",
]
)
def test_revert_journal(self, vm_on_linstor_sr: VM, defer: Defer, exit_on_fistpoint: None, fistpoint: str):
check_vdi_revert_journal(defer, vm_on_linstor_sr, fistpoint, vm_on_linstor_sr.host.pool.master)

@pytest.mark.small_vm
@pytest.mark.big_vm
def test_critical_journal_revert(
self, vm_on_linstor_sr: VM, defer: Defer, exit_on_fistpoint: None, hostA2: Host
) -> None:
# Linstor monitor service might run a scan during critical journal testing
# We disable the service while testing
for host in vm_on_linstor_sr.host.pool.hosts:
host.ssh("systemctl stop linstor-monitor.service")
defer(lambda: host.ssh("systemctl start linstor-monitor.service"))

@glehmann glehmann Jul 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it should rather be implemented as a linstor_no_monitor fixture

@klmp200 klmp200 Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)


check_critical_journal_revert(defer, vm_on_linstor_sr, hostA2, "LinstorSR_revert_create_src")

# *** tests with reboots (longer tests).

@pytest.mark.reboot
Expand Down
Loading