[pending feature merge] Create tests for vdi_revert on linstorsr - #632
Open
klmp200 wants to merge 2 commits into
Open
[pending feature merge] Create tests for vdi_revert on linstorsr#632klmp200 wants to merge 2 commits into
klmp200 wants to merge 2 commits into
Conversation
Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
This was referenced Jul 17, 2026
glehmann
reviewed
Jul 17, 2026
| # We disable the service while testing | ||
| for host in vm_on_linstor_sr.host.pool.hosts: | ||
| host.ssh("systemctl stop linstor-monitor.service") | ||
| defer(lambda: host.ssh("systemctl start linstor-monitor.service")) |
Member
There was a problem hiding this comment.
IMO it should rather be implemented as a linstor_no_monitor fixture
Millefeuille42
approved these changes
Jul 17, 2026
Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
glehmann
approved these changes
Jul 17, 2026
glehmann
approved these changes
Jul 17, 2026
stormi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements tests for
vdi_reverton linstorsrRequired smapi changes: xcp-ng/sm#132
Stacked PR review
vdi_reverton lvm based SRs #631