Fixes for install/upgrade tests - #682
Draft
glehmann wants to merge 3 commits into
Draft
Conversation
Include the msg parameter in the TimeoutError raised by wait_for so that timeout failures include the human-readable description of what was being waited for. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
The default target verification can fail transiently early after boot while units are still being loaded. Retry the analysis with wait_for so only persistent issues fail the test. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
ydirson
reviewed
Aug 25, 2026
ydirson
left a comment
ydirson
left a comment
Collaborator
There was a problem hiding this comment.
Doesn't it make sense to wait for default target to be reached before verification, instead of looping till it passes?
Comment on lines
-209
to
+210
| "Timeout reached while waiting for fn call to yield %s (%s)." % (expected, timeout_secs) | ||
| "Timed out after %ss waiting for condition to be %s%s" % (timeout_secs, expected, suffix) |
Collaborator
There was a problem hiding this comment.
An example output would help
Member
Author
There was a problem hiding this comment.
previously, it looked like:
FAILED tests/unit/test_rescan_block_devices_info.py::test_timeout - TimeoutError: Timeout reached while waiting for fn call to yield True (10).
with this change:
FAILED tests/unit/test_rescan_block_devices_info.py::test_timeout - TimeoutError: Timed out after 10s waiting for condition to be True: Wait for coalesce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.