Skip to content

Fixes for install/upgrade tests #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
glehmann wants to merge 3 commits into
base: master
Choose a base branch
from
+20 −12
Draft

Fixes for install/upgrade tests #682

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56794bc
lib/common: include context message in TimeoutError
glehmann Jul 21, 2026
8dd9d8e
Log memory usage and the 10 processes using the most memory
glehmann Jul 31, 2026
efef93a
test_systemd: retry systemd-analyze verify until it passes
glehmann Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,9 @@ def wait_for(fn: Callable[[], object], msg: str | None = None, timeout_secs: int
return
if time.perf_counter() - start_time >= timeout_secs:
expected = 'True' if not invert else 'False'
suffix = ": " + msg if msg else ""
raise TimeoutError(
"Timeout reached while waiting for fn call to yield %s (%s)." % (expected, timeout_secs)
"Timed out after %ss waiting for condition to be %s%s" % (timeout_secs, expected, suffix)
Comment on lines -209 to +210

@ydirson ydirson Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example output would help

@glehmann glehmann Aug 25, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously, it looked like:

FAILED tests/unit/test_rescan_block_devices_info.py::test_timeout - TimeoutError: Timeout reached while waiting for fn call to yield True (10).

with this change:

FAILED tests/unit/test_rescan_block_devices_info.py::test_timeout - TimeoutError: Timed out after 10s waiting for condition to be True: Wait for coalesce.

)
time.sleep(retry_delay_secs)

Expand Down