Repository navigation
pkg_in_pipe: write a machine readable version of the report - #839
Merged
Merged
Conversation
This was referenced Aug 26, 2026
gduperrey
approved these changes
Aug 31, 2026
glehmann
force-pushed
the
gln/json-report-output-onkp
branch
2 times, most recently
from
September 29, 2026 09:48
3d76ca1 to
8b08ba1
Compare
glehmann
changed the base branch from
gln/pkg-in-pipe-updates-psmx
to
master
September 29, 2026 15:19
vxgmichel
approved these changes
Sep 29, 2026
vxgmichel
left a comment
vxgmichel
left a comment
Contributor
There was a problem hiding this comment.
A minor comment, LGTM otherwise 👍
Comment on lines
+448
to
+481
| previous_build_sha = find_previous_build_commit(tag, build) | ||
| previous_build = find_previous_build(tag, build) | ||
| previous_build_sha = None | ||
| if previous_build is not None: | ||
| source = previous_build.get('source') or MISSING_SOURCES.get(previous_build['nvr']) | ||
| previous_build_sha = parse_source(source)[1] |
Contributor
There was a problem hiding this comment.
Maybe update find_previous_build to be more like find_previous_build_with_commit and have it return both the build and the commit? This way, you don't have to duplicate the following line:
source = previous_build.get('source') or MISSING_SOURCES.get(previous_build['nvr'])This also lets you document better that we stop at the most recent build that provides a source commit.
The report is written as a json file that other scripts can consume, e.g. to generate the release post or to move the plane cards of the builds to another state. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/json-report-output-onkp
branch
from
September 29, 2026 19:21
8b08ba1 to
bc4028b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The report is written as a json file that other scripts can consume,
e.g. to generate the release post or to move the plane cards of the
builds to another state.
Signed-off-by: Gaëtan Lehmann gaetan.lehmann@vates.tech
This PR is part of a tree containing 4 PRs:
mastermaster