Repository navigation
Conversation
gduperrey
left a comment
There was a problem hiding this comment.
It bothers me a bit that the cards are being moved via a script based on the build location.
I’m worried we might start moving them just to keep things in sync, without verifying them first, which could result in them being incomplete.
|
I think a motivation is missing to this PR, as well as a description of the process update. It's already possible to bulk-move cards via the UI, and as others pointed out, moving states is supposed to come with checking that the conditions are met. The question is whether updating the cards status is a formality that needs to be automated, or the occasion for the release team to check that everything is in order. In particular, I'm against moving to "released" automatically without seeing any description of the new process, because that's currently when we check one last time that no documentation update is missing (though, at this stage, is rather late), and that we contact users in tickets, forum or github to let them know about a specific fix or feature they were waiting for. So, to consider this automation, we need to understand what the release process looks like with this tool. |
7af595e to
c6ec416
Compare
3d76ca1 to
8b08ba1
Compare
c6ec416 to
6ef8fd9
Compare
There was a problem hiding this comment.
i dont think you want to commit this
add *.pyc to gitignore ;)
| from pydantic import BaseModel | ||
|
|
||
| PLANE_BASE_URL = ( | ||
| 'https://project.vates.tech/api/v1/workspaces/vates-global/projects/' |
There was a problem hiding this comment.
do we want to hardcode internal urls here ? I would prefer env vars like you are doing later with PLANE_TOKEN
|
|
||
| # Move the cards to a state | ||
|
|
||
| The `move_cards_to_state.py` script moves the plane cards linked to the builds of a koji tag to a |
There was a problem hiding this comment.
nitpicking: I would name file with a plane- prefix
cfdf094 to
b215c66
Compare
6ef8fd9 to
506c4e0
Compare
b215c66 to
e193d96
Compare
506c4e0 to
0292ba0
Compare
b215c66 to
e193d96
Compare
506c4e0 to
0292ba0
Compare
0292ba0 to
57ea2fe
Compare
e193d96 to
2a4af26
Compare
…s during the generation (#849) * Fix plane connection error blocking the script execution It's meant to generate a message in the report, not block the report generation Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech> * pkg_in_pipe: log the progress, the cache usage and the source problems during the generation Add a --debug option and log the koji tag and the build being processed, whether values come from the cache or are fetched again, and warn when the plane tickets or github can't be reached, using the same logger setup as gen-dnf-proxy.py. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech> --------- Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
…tate Add move_cards_to_state.py, which keeps the plane cards of the XCPNG project in sync with the progress of the builds: the cards linked to the builds of a given koji tag are moved to a given state, and never backwards. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
57ea2fe to
2e3edf6
Compare
Add move_cards_to_state.py, which keeps the plane cards of the XCPNG
project in sync with the progress of the builds: the cards linked to
the builds of a given koji tag are moved to a given state, and never
backwards.
Signed-off-by: Gaëtan Lehmann gaetan.lehmann@vates.tech
This PR is part of a tree containing 4 PRs:
mastermaster