Skip to content

pkg_in_pipe: move the plane cards of the builds of a tag to a given state - #840

Closed
glehmann wants to merge 2 commits into
gln/pkg-in-pipe-logging-debug-zvvkfrom
gln/sync-plane-cards-mktk
Closed

glehmann wants to merge 2 commits into
gln/pkg-in-pipe-logging-debug-zvvkfrom
gln/sync-plane-cards-mktk

Conversation

@glehmann

@glehmann glehmann commented Aug 26, 2026 •

Copy link
Copy Markdown
Member

Add move_cards_to_state.py, which keeps the plane cards of the XCPNG
project in sync with the progress of the builds: the cards linked to
the builds of a given koji tag are moved to a given state, and never
backwards.

Signed-off-by: Gaëtan Lehmann gaetan.lehmann@vates.tech

This PR is part of a tree containing 4 PRs:

  1. master
  2. pkg_in_pipe: write a machine readable version of the report #839 → master
  3. pkg_in_pipe: log the progress, the cache usage and the source problems during the generation #849 → pkg_in_pipe: write a machine readable version of the report #839
  4. "pkg_in_pipe: move the plane cards of the builds of a tag to a given state" (this PR) → pkg_in_pipe: log the progress, the cache usage and the source problems during the generation #849
  5. pkg_in_pipe: generate a draft of the release post from the report #841 → pkg_in_pipe: log the progress, the cache usage and the source problems during the generation #849

@gduperrey gduperrey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It bothers me a bit that the cards are being moved via a script based on the build location.

I’m worried we might start moving them just to keep things in sync, without verifying them first, which could result in them being incomplete.

@gduperrey
gduperrey requested a review from a team August 31, 2026 15:11

@rzr rzr left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is welcome but prone to mistakes, I saw some cards with open PRs that were marked released while they should have been not touched. I would prompt user to list or confirm each stage change

@stormi

stormi commented Aug 31, 2026

Copy link
Copy Markdown
Member

I think a motivation is missing to this PR, as well as a description of the process update. It's already possible to bulk-move cards via the UI, and as others pointed out, moving states is supposed to come with checking that the conditions are met.

The question is whether updating the cards status is a formality that needs to be automated, or the occasion for the release team to check that everything is in order.

In particular, I'm against moving to "released" automatically without seeing any description of the new process, because that's currently when we check one last time that no documentation update is missing (though, at this stage, is rather late), and that we contact users in tickets, forum or github to let them know about a specific fix or feature they were waiting for.

So, to consider this automation, we need to understand what the release process looks like with this tool.

@glehmann
glehmann force-pushed the gln/sync-plane-cards-mktk branch from 7af595e to c6ec416 Compare September 29, 2026 09:15
@glehmann
glehmann force-pushed the gln/json-report-output-onkp branch from 3d76ca1 to 8b08ba1 Compare September 29, 2026 09:48
@glehmann
glehmann force-pushed the gln/sync-plane-cards-mktk branch from c6ec416 to 6ef8fd9 Compare September 29, 2026 09:48

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think you want to commit this

add *.pyc to gitignore ;)

from pydantic import BaseModel

PLANE_BASE_URL = (
'https://project.vates.tech/api/v1/workspaces/vates-global/projects/'

@rzr rzr Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to hardcode internal urls here ? I would prefer env vars like you are doing later with PLANE_TOKEN


# Move the cards to a state

The `move_cards_to_state.py` script moves the plane cards linked to the builds of a koji tag to a

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking: I would name file with a plane- prefix

@glehmann
glehmann changed the base branch from gln/json-report-output-onkp to gln/pkg-in-pipe-logging-debug-zvvk September 29, 2026 15:19
@glehmann
glehmann force-pushed the gln/pkg-in-pipe-logging-debug-zvvk branch from cfdf094 to b215c66 Compare September 29, 2026 15:23
@glehmann
glehmann force-pushed the gln/sync-plane-cards-mktk branch from 6ef8fd9 to 506c4e0 Compare September 29, 2026 15:23
@glehmann
glehmann force-pushed the gln/pkg-in-pipe-logging-debug-zvvk branch from b215c66 to e193d96 Compare September 29, 2026 15:29
@glehmann
glehmann force-pushed the gln/sync-plane-cards-mktk branch from 506c4e0 to 0292ba0 Compare September 29, 2026 15:29
@glehmann
glehmann force-pushed the gln/pkg-in-pipe-logging-debug-zvvk branch from b215c66 to e193d96 Compare September 29, 2026 15:29
@glehmann
glehmann force-pushed the gln/sync-plane-cards-mktk branch from 506c4e0 to 0292ba0 Compare September 29, 2026 15:29
@glehmann
glehmann marked this pull request as draft September 29, 2026 15:29
@glehmann
glehmann force-pushed the gln/sync-plane-cards-mktk branch from 0292ba0 to 57ea2fe Compare September 29, 2026 19:21
@glehmann
glehmann force-pushed the gln/pkg-in-pipe-logging-debug-zvvk branch from e193d96 to 2a4af26 Compare September 29, 2026 19:21
glehmann and others added 2 commits October 8, 2026 09:41
…s during the generation (#849)

* Fix plane connection error blocking the script execution

It's meant to generate a message in the report, not block the report
generation

Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>

* pkg_in_pipe: log the progress, the cache usage and the source problems during the generation

Add a --debug option and log the koji tag and the build being processed, whether
values come from the cache or are fetched again, and warn when the plane tickets
or github can't be reached, using the same logger setup as gen-dnf-proxy.py.

Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>

---------

Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
…tate

Add move_cards_to_state.py, which keeps the plane cards of the XCPNG
project in sync with the progress of the builds: the cards linked to
the builds of a given koji tag are moved to a given state, and never
backwards.

Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
glehmann force-pushed the gln/sync-plane-cards-mktk branch from 57ea2fe to 2e3edf6 Compare October 8, 2026 07:45
@glehmann
glehmann deleted the branch gln/pkg-in-pipe-logging-debug-zvvk October 8, 2026 07:46
@glehmann glehmann closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants