-
-
Notifications
You must be signed in to change notification settings - Fork 497
Auto-update vulkanscenegraph to v1.1.12 #8845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the process of keeping the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request automatically updates the vulkanscenegraph package to version v1.1.12. The change itself is correct. However, it highlights a pre-existing inconsistency in version naming within the package definition file. I've added a comment with a suggestion to address this to improve the overall reliability of the package definitions.
| add_urls("https://github.com/vsg-dev/VulkanSceneGraph/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/vsg-dev/VulkanSceneGraph.git") | ||
|
|
||
| add_versions("v1.1.12", "bd9c58f615d44a4de684fc0c97acc010a548a6714a64c98c59ee2b86f3e66e3d") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new version correctly uses the v prefix. It's important for all versions in this package definition to have a consistent prefixing scheme that matches the upstream repository's tags to ensure they can be downloaded correctly via the URL template on line 6. I've noticed that not all existing version entries follow this pattern, which could lead to download failures for those specific versions. It would be beneficial to correct these inconsistencies for improved package reliability.
New version of vulkanscenegraph detected (package version: v1.1.10, last github version: v1.1.12)