Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/v/vulkanscenegraph/xmake.lua
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package("vulkanscenegraph")
add_urls("https://github.com/vsg-dev/VulkanSceneGraph/archive/refs/tags/$(version).tar.gz",
"https://github.com/vsg-dev/VulkanSceneGraph.git")

add_versions("v1.1.12", "bd9c58f615d44a4de684fc0c97acc010a548a6714a64c98c59ee2b86f3e66e3d")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This new version correctly uses the v prefix. It's important for all versions in this package definition to have a consistent prefixing scheme that matches the upstream repository's tags to ensure they can be downloaded correctly via the URL template on line 6. I've noticed that not all existing version entries follow this pattern, which could lead to download failures for those specific versions. It would be beneficial to correct these inconsistencies for improved package reliability.

add_versions("v1.1.10", "b430132ba5454e0616ff5334a7cb9196c0e8f10a925c2106e80a78d6f24ae4b5")
add_versions("1.0.2", "526acd58d6e3a3bd3c3169996e0616d5c4a01e793dc064e8d20217791743bab5")

Expand Down
Loading