Skip to content

Conversation

@xbuffat
Copy link

@xbuffat xbuffat commented Feb 28, 2025

Description

The sign convention of the longitudinal wake (positive means energy loss) is opposite to PyHT. The sign changed is adjusted in the conversion factor when reading the file.

Closes # .

Checklist

Mandatory:

  • I have added tests to cover my changes
  • All the tests are passing, including my new ones
  • I described my changes in this PR description

Optional:

  • The code I wrote follows good style practices (see PEP 8 and PEP 20).
  • I have updated the docs in relation to my changes, if applicable
  • I have tested also GPU contexts

@giadarol
Copy link
Member

Decided to keep the present convention choice

@giadarol giadarol closed this Mar 30, 2025
@xbuffat xbuffat deleted the fixHTSignConv branch April 7, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants