Skip to content

Fix sign of longitudinal wake when reading from headtail file #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix sign of longitudinal wake when reading from headtail file #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28eb3a9
Fix sign convention for longiotudinal wake from HEADTAIL tables
xbuffat Feb 28, 2025
f9873a9
Adjust tests to HT convention
xbuffat Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_xwakes_headtail_table_read.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def test_headail_table_read():
for i_component, component in enumerate(wake_file_columns):
if component != 'time':
if component == 'longitudinal':
conversion_factor = 1E12
conversion_factor = -1E12
else:
conversion_factor = 1E15

Expand Down
4 changes: 2 additions & 2 deletions xwakes/read_headtail_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def read_headtail_file(wake_file, wake_file_columns):
if component != 'time':
assert component in valid_wake_components
if component == 'longitudinal':
conversion_factor = 1E12
conversion_factor = -1E12
else:
conversion_factor = 1E15

Expand All @@ -45,4 +45,4 @@ def read_headtail_file(wake_file, wake_file_columns):

df = pd.DataFrame(data=dict_components)

return df
return df
Loading