Skip to content

XWIKI-23097: Quicksearch: no alert when results are shown #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented May 5, 2025

Jira URL

https://jira.xwiki.org/browse/XWIKI-23097

Changes

Description

  • Added the alert role to the container of suggestions.

Clarifications

  • The component is already pretty accessible, but nothing was conveyed to notice the users that some new content has been queried and displayed. This attribute is enough to fulfill this lack of info.
  • There is a lot of info read out when the dropdown is activated. This is an issue for clarity, but I guess it's not that important and it's better than no information at all.

Screenshots & Video

Video demo with the changes proposed here applied:

2025-05-05.17-01-10.mp4

Made using browserStack, Chrome 136 + NVDA

Note that before the changes in here were applied, all that would be read out to the user are the letters they added to the input:

p
a
g
e

Now, as we can listen to in this demo, those letters are followed by the content of the asynchronously generated dropdown:

p
a
g
e
Go to search page button.
[...]

Executed Tests

Manual tests, see above.
https://github.com/search?q=org%3Axwiki+suggestItems&type=code shows that the changes do not affect the pageobject associated to this element used in docker tests.

Successfully built mvn clean install -f xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/ -Pquality.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 16.10.X, this is a minor bug with a very low risk solution.

Sereza7 added 2 commits May 5, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant