Skip to content

XWIKI-23097: Quicksearch: no alert when results are shown #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -494,8 +494,14 @@ var XWiki = (function(XWiki){

if (!$(this.options.parentContainer).down('.suggestItems')) {
// If the suggestion top container is not in the DOM already, we create it and inject it

var div = new Element("div", { 'class': "suggestItems "+ this.options.className });

// We populate the suggestion container with information that was not on the page.
// This meaningful change in the DOM must be announced
// so that assistive technology users can notice it without trouble.
var div = new Element("div", {
'class': "suggestItems "+ this.options.className,
'role': 'alert'
});

// Get position of target textfield
var pos = $(this.options.parentContainer).tagName.toLowerCase() == 'body' ? this.fld.cumulativeOffset() : this.fld.positionedOffset();
Expand Down