Add new responsive algorithm#152
Conversation
Actually take up 100% of the window width - ignore, height, as we're calculating the width here.
Josh-Cena
left a comment
There was a problem hiding this comment.
It may be a bad idea to hardcode the width in general, because as the issue said, this made the container unstylable. I'm also not a fan of two options that only differ in a magic constant. Maybe we can defer the width calculation to CSS, and then here use something like getClientBoundingBox to retrieve the dimensions instead?
|
I'm also not a fan of another variant, but it's the only way to do this without breaking api. I couldn't get a bounding rect approach to work like I wanted. |
|
Can we improve this somehow? |
|
IMO, |
|
That would be helpful I guess. The idea with size as number is good, but it would be much easier, for my usecase, if I could set the height and the width would be automatically calculated. |
Actually take up 100% of the window width - ignore, height, as we're calculating the width here.
Might fix #149