LRS-30 Backwards Compatibility with 1.0.x#40
Merged
milt merged 18 commits intoLRS-30_2_0_compatfrom Aug 22, 2025
Merged
Conversation
milt
added a commit
that referenced
this pull request
Oct 6, 2025
* LRS-30 #comment passing LRS-2.0 branch of conformance tests in clj + cljs!!! * LRS-30 #comment remove hack for incorrect headers in tests * LRS-30 working in clj but now failing in cljs * LRS-30 proper lower casing of header to fix cljs * new version of test runner with branch selection * LRS-30 update conf test up checker * set dep back so testing w/branch works * add vscode to ignore * master branch 2.0.0 for clj sync/async * same for cljs * fix etag header validation * don't accept non-unique ids * last-mod headers for async clj * add proper conc header processing for sync state * last-mod for sync * better id check * refactored doc etag stuff * return unknown activity * recent clojure(script) and latest 2.0 xapi-schema * normalize durations prior to signed statement comparison * add test for duration norm * LRS-30 Backwards Compatibility with 1.0.x (#40) * LRS-30 backwards compatible but now fails both branches * LRS-30 fix alt syntax backwards compat, more issues remain * LRS-30 return a valid old version if specified * conditional version dispatch for doc etag behavior * test multiple versions * remove println * deps * bump tmp * correct sync doc handling * bump cljs * fix cljs multipart handling * bump ci java version * add deployment java version * use updated xapi-schema with bindable spec version * fix cljs where there are no pedestal bindings * remove TODO the unique check is good practice * collect contextAgents and contextGroups in library fns * make sure timestamp normalization uses T * also store binding version as data for use in various places * consistently derive version response header * correct interceptor order * dispatch on version for activities behavior * explicit list of supported versions * simplify context version * pass context to every method of the impl * switch conf tests back to master * release 1.4.1 of xapi-schema * reenable instrumentation on GET /about * Revert "reenable instrumentation on GET /about" This reverts commit 5118e4b. * reenable failing cljs specs in clj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backwards compatible but now fails both branches
Blocked by adlnet/lrs-conformance-test-suite#252
See adlnet/lrs-conformance-test-suite#252 (comment)