[#31504] macOS test: Skip anonymizer-backup tests on non-Linux platforms#31505
Open
ellabaron-code wants to merge 1 commit into
Open
[#31504] macOS test: Skip anonymizer-backup tests on non-Linux platforms#31505ellabaron-code wants to merge 1 commit into
ellabaron-code wants to merge 1 commit into
Conversation
YB Controller is only built/supported on Linux, so skip the YBBackupWithAnonymizerTest fixture's SetUp on other platforms. This skips both RestoreAfterRoleRenameWithAnonymizer and CloneAfterRoleRenameWithAnonymizer (whose fixture inherits from YBBackupWithAnonymizerTest) on macOS rather than failing.
✅ Deploy Preview for infallible-bardeen-164bc9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the YBBackupWithAnonymizerTest in yb-backup-during-ddl-test.cc to skip execution on non-Linux platforms using GTEST_SKIP(), as the YB Controller is only supported on Linux. There are no review comments to address, and I have no further feedback to provide.
Contributor
|
trigger jenkins |
Contributor
|
Jenkins build has been triggered. Results will be posted once it completes. CSI JenkinsBot |
Contributor
|
❌ Jenkins build for commit Errors:
Checking for number of tests planned versus executed.
🔨 DB Build/Test Job Summary
JenkinsBot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YBBackupWithAnonymizerTestand the tests derived from its fixture (RestoreAfterRoleRenameWithAnonymizerandCloneAfterRoleRenameWithAnonymizer) require YB Controller, which is only built/supported on Linux. On non-Linux platforms (e.g. macOS) the fixture'sSetUp()fails rather than skipping, so the tests are reported as failures.This change skips the fixture's setup on non-Linux platforms via
GTEST_SKIP(), which causes both tests to be reported as skipped on macOS instead of failing.Fixes #31504.
Test plan
RestoreAfterRoleRenameWithAnonymizerandCloneAfterRoleRenameWithAnonymizerare reported as skipped instead of failing.CSI