Skip to content

[#31504] macos-test: Skip anonymizer-backup tests on non-Linux platforms #31505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahulb-yb merged 5 commits into from
Jun 18, 2026
+3 −5
Merged

[#31504] macos-test: Skip anonymizer-backup tests on non-Linux platforms #31505

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40f92f4
Skip anonymizer-backup tests on non-Linux platforms
ellabaron-code May 7, 2026
ef17a83
made the fix compliant with the other tests
ellabaron-code Jun 10, 2026
a9fbf34
made the fix compliant with the other tests
ellabaron-code Jun 10, 2026
4e544cc
fixed code review comment
ellabaron-code Jun 17, 2026
2d28247
fixed code review comment
ellabaron-code Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/yb/tools/yb-backup/yb-backup-during-ddl-test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ using yb::client::YBTableName;
DECLARE_bool(TEST_enable_sync_points);
DECLARE_bool(TEST_mark_snapshot_as_failed);
DECLARE_bool(TEST_use_custom_varz);
DECLARE_bool(TEST_use_yb_controller);
DECLARE_bool(enable_pg_anonymizer);
DECLARE_bool(ysql_beta_features);

Expand Down Expand Up @@ -933,8 +932,10 @@ TEST_P(YBBackupDuringAlterTable, RenameColumn) {
class YBBackupWithAnonymizerTest : public YBBackupDuringDdl {
public:
void SetUp() override {
if (!UseYbController()) {
GTEST_SKIP() << "Test requires YBC";
}
ANNOTATE_UNPROTECTED_WRITE(FLAGS_enable_pg_anonymizer) = true;
ANNOTATE_UNPROTECTED_WRITE(FLAGS_TEST_use_yb_controller) = true;
YBBackupDuringDdl::SetUp();
CreateDatabase(kBackupSourceDbName);
}
Expand Down Expand Up @@ -975,9 +976,6 @@ class YBBackupWithAnonymizerTest : public YBBackupDuringDdl {
// encounters "role does not exist" errors for the GRANT statements. The restore itself
// should succeed and ignore the errors because --dump-role-checks is used.
TEST_F(YBBackupWithAnonymizerTest, RestoreAfterRoleRenameWithAnonymizer) {
if (!UseYbController()) {
GTEST_SKIP() << "Test requires YBC";
}

auto conn = ASSERT_RESULT(SetUpAnonymizer());
const string backup_dir = GetTempDir("backup");
Expand Down
Loading