Skip to content

Fix skipping fields with union of unsupported type#722

Merged
yukinarit merged 1 commit intoyukinarit:mainfrom
AllanChain:fix/skip-union
Feb 17, 2026
Merged

Fix skipping fields with union of unsupported type#722
yukinarit merged 1 commit intoyukinarit:mainfrom
AllanChain:fix/skip-union

Conversation

@AllanChain
Copy link
Copy Markdown
Contributor

@AllanChain AllanChain commented Feb 16, 2026

Fixes #721

The unformatted files are not touched in this PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.81%. Comparing base (f09d503) to head (f28c811).
⚠️ Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   90.83%   90.81%   -0.02%     
==========================================
  Files          13       13              
  Lines        2040     2308     +268     
  Branches      370      450      +80     
==========================================
+ Hits         1853     2096     +243     
- Misses        124      141      +17     
- Partials       63       71       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Owner

@yukinarit yukinarit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yukinarit yukinarit added the bug Bug report or fix label Feb 17, 2026
@yukinarit yukinarit merged commit 182ef91 into yukinarit:main Feb 17, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug report or fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-serde fields are not skipped correctly if it's a union

2 participants