Skip to content

Fix skipping fields with union of unsupported type #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yukinarit merged 1 commit into from
Feb 17, 2026
+4 −1
Merged

Fix skipping fields with union of unsupported type #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion serde/compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,8 @@ def recursive(cls: TypeLike) -> None:
stack.append(cls)
if isinstance(cls, type):
for f in dataclass_fields(cls):
recursive(f.type)
if not f.metadata.get("serde_skip"):
recursive(f.type)
stack.pop()
elif is_opt(cls):
args = type_args(cls)
Expand Down
2 changes: 2 additions & 0 deletions tests/test_basics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,6 +867,7 @@ def __init__(self, value: int = 42) -> None:
class Foo:
name: str
internal: UnsupportedClass = serde.field(default_factory=UnsupportedClass, skip=True)
internal_union: UnsupportedClass | None = serde.field(default=None, skip=True)

# Serialization should work
f = Foo(name="test")
Expand All @@ -876,6 +877,7 @@ class Foo:
restored = serde.from_dict(Foo, {"name": "test"})
assert restored.name == "test"
assert isinstance(restored.internal, UnsupportedClass)
assert restored.internal_union is None

# Also test with List of unsupported types
@serde.serde
Expand Down
Loading