fix: improve bearerinjector logging for missing credentials#3957
Merged
MustafaSaber merged 2 commits intoApr 13, 2026
Conversation
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
szuecs
requested changes
Apr 9, 2026
| `"Bearer "` prefix and empty suffix. | ||
|
|
||
| The token file must be located in a directory passed via the `-credentials-paths` flag. | ||
| See the [egress reference](https://opensource.zalando.com/skipper/reference/egress/#example-bearer-injection) |
Member
There was a problem hiding this comment.
Please use relative markdown links
| b, ok := f.secretsReader.GetSecret(f.secretName) | ||
| if !ok { | ||
| log.Errorf("Secret %q not found for bearerinjector filter", f.secretName) | ||
| log.Errorf("Secret %q not found for bearerinjector filter. Make sure the file exists in a directory passed via -credentials-paths flag.", f.secretName) |
Member
There was a problem hiding this comment.
Better to have the link to docs here
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
Contributor
Author
|
Fixed both - switched to relative markdown link in filters.md and added the docs URL to the error message in bearer.go. Pushed in 6f19f0b. |
Contributor
|
Please fix DCO |
When GetSecret fails, the error message now mentions the -credentials-paths flag so users know how to configure the secret source. Also updates the bearerinjector documentation to link to the egress reference and note the -credentials-paths requirement. Fixes zalando#3507 Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
- Use relative markdown link for egress reference in filters.md - Include docs URL in bearerinjector error log for easier debugging Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
mvanhorn
force-pushed
the
osc/3507-bearerinjector-logging
branch
from
April 10, 2026 17:24
6f19f0b to
72388f8
Compare
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
szuecs
approved these changes
Apr 11, 2026
MustafaSaber
approved these changes
Apr 13, 2026
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the bearerinjector filter can't find a secret, the error message now mentions the
-credentials-pathsflag. Previously it just said "Secret not found" with no hint about what to configure.Also updates the bearerinjector docs to link to the egress reference and note the
-credentials-pathsrequirement.Changes
filters/auth/bearer.go: Improved error message at line 56 to mention-credentials-paths.docs/reference/filters.md: Added note about-credentials-pathsand link to the egress reference with a complete configuration example.Testing
go build ./filters/auth/...passesFixes #3507
This contribution was developed with AI assistance (Claude Code).