Skip to content

fix: improve bearerinjector logging for missing credentials #3957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MustafaSaber merged 2 commits into from
Apr 13, 2026
Merged

fix: improve bearerinjector logging for missing credentials #3957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dca86a
fix: improve bearerinjector logging for missing credentials
mvanhorn Apr 9, 2026
72388f8
fix: use relative doc link, add docs URL to error message
mvanhorn Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/reference/filters.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3463,6 +3463,10 @@ from file providing the token as content.
It is a special form of `setRequestHeaderFromSecret` with `"Authorization"` header name,
`"Bearer "` prefix and empty suffix.

The token file must be located in a directory passed via the `-credentials-paths` flag.
See the [egress reference](egress.md#example-bearer-injection)
for a complete configuration example.

Example:

```
Expand All @@ -3471,6 +3475,9 @@ egress: * -> bearerinjector("/tmp/secrets/my-token") -> "https://api.example.com
// equivalent to setRequestHeaderFromSecret("Authorization", "/tmp/secrets/my-token", "Bearer ")
```

Note: You must start skipper with `-credentials-paths=/tmp/secrets` for the
filter to find the token file.

## Open Tracing
### tracingBaggageToTag

Expand Down
2 changes: 1 addition & 1 deletion filters/auth/bearer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func newBearerInjectorFilter(s string, sr secrets.SecretsReader) *bearerInjector
func (f *bearerInjectorFilter) Request(ctx filters.FilterContext) {
b, ok := f.secretsReader.GetSecret(f.secretName)
if !ok {
log.Errorf("Secret %q not found for bearerinjector filter", f.secretName)
log.Errorf("Secret %q not found for bearerinjector filter. Make sure the file exists in a directory passed via -credentials-paths flag. See https://opensource.zalando.com/skipper/reference/egress/#example-bearer-injection", f.secretName)
return
}
ctx.Request().Header.Set(authHeaderName, authHeaderPrefix+string(b))
Expand Down
Loading