Skip to content

refactor(gateway-contracts): improve pause all contracts method behavior#1747

Merged
mergify[bot] merged 5 commits intomainfrom
isaac/833/refactor/improve-pause-all-contracts-method-behavior
Mar 26, 2026
Merged

refactor(gateway-contracts): improve pause all contracts method behavior#1747
mergify[bot] merged 5 commits intomainfrom
isaac/833/refactor/improve-pause-all-contracts-method-behavior

Conversation

@isaacdecoded
Copy link
Copy Markdown
Contributor

@isaacdecoded isaacdecoded commented Jan 8, 2026

@cla-bot cla-bot bot added the cla-signed label Jan 8, 2026
@isaacdecoded isaacdecoded marked this pull request as ready for review January 8, 2026 10:40
@isaacdecoded isaacdecoded requested a review from a team as a code owner January 8, 2026 10:40
@isaacdecoded isaacdecoded requested a review from jatZama January 8, 2026 10:40
@mergify
Copy link
Copy Markdown

mergify bot commented Jan 8, 2026 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 5d79fb1.

🟢 All jobs passed!

But CI Insights is watching 👀

jatZama
jatZama reviewed Jan 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jatZama jatZama left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is sound, great work.
I think you should bump the version (MINOR_VERSION and REINITIALIZER_VERSION) of GatewayConfig contract, wdyt? Or is the version bumping done only right before deployment the upgraded version? I don't remember.

@isaacdecoded isaacdecoded requested a review from a team as a code owner January 8, 2026 11:11
@isaacdecoded
Copy link
Copy Markdown
Contributor Author

isaacdecoded commented Jan 8, 2026

The logic is sound, great work. I think you should bump the version (MINOR_VERSION and REINITIALIZER_VERSION) of GatewayConfig contract, wdyt? Or is the version bumping done only right before deployment the upgraded version? I don't remember.

@jatZama, versions bumped here. Also enabled the upgrade tests CI. Thanks for the catch! ✊

@isaacdecoded isaacdecoded requested a review from jatZama January 8, 2026 11:24
@isaacdecoded isaacdecoded force-pushed the isaac/833/refactor/improve-pause-all-contracts-method-behavior branch from 5d79fb1 to d3fb32f Compare March 23, 2026 14:56
@isaacdecoded isaacdecoded force-pushed the isaac/833/refactor/improve-pause-all-contracts-method-behavior branch from f04582a to 7923cd3 Compare March 24, 2026 11:48
zmalatrax
zmalatrax reviewed Mar 24, 2026
View reviewed changes
zmalatrax
zmalatrax reviewed Mar 24, 2026
View reviewed changes
isaacdecoded and others added 2 commits March 25, 2026 11:55
@isaacdecoded @zmalatrax
Update gateway-contracts/contracts/GatewayConfig.sol
44205ad 
Co-authored-by: malatrax <71888134+zmalatrax@users.noreply.github.com>
@isaacdecoded
refactor(gateway-contracts): use stored local variables to avoid mult…
f010afa 
…iple static calls
@isaacdecoded isaacdecoded requested a review from zmalatrax March 25, 2026 11:00
zmalatrax
zmalatrax approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@zmalatrax zmalatrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@isaacdecoded
Copy link
Copy Markdown
Contributor Author

isaacdecoded commented Mar 26, 2026

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 26, 2026 •
edited
Loading

Merge Queue Status

This pull request spent 44 minutes 40 seconds in the queue, including 44 minutes 18 seconds running CI.

Required conditions to merge

@mergify mergify bot added the queued label Mar 26, 2026
mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify
Merge of #1747
3510678
This was referenced Mar 26, 2026
Closed
Merged
Merged
@mergify mergify bot added the merge-queued label Mar 26, 2026
@mergify mergify bot merged commit a4e85ae into main Mar 26, 2026
64 of 65 checks passed
@mergify mergify bot deleted the isaac/833/refactor/improve-pause-all-contracts-method-behavior branch March 26, 2026 11:45
mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify
Merge of #1747
40e25e7
mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify
Merge of #1747
6a38617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmalatrax zmalatrax zmalatrax approved these changes

@jatZama jatZama Awaiting requested review from jatZama

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@isaacdecoded @zmalatrax @jatZama