refactor(common): align hardhat task arguments and definitions#2163
refactor(common): align hardhat task arguments and definitions#2163mergify[bot] merged 2 commits intomainfrom
Conversation
0bf76da to
322725a
Compare
zmalatrax
left a comment
There was a problem hiding this comment.
host-contracts/tasks/taskUtils.ts still uses fs.readFileSync + dotenv.parse
File: host-contracts/tasks/taskUtils.ts:40,62
This file still has the old pattern with customKmsVerifierAddress / customInputVerifierAddress params and dotenv.parse(fs.readFileSync('addresses/.env.host')).
zmalatrax
left a comment
There was a problem hiding this comment.
gateway-contracts/tasks/reshareKeys.ts still uses inline dotenv.config
File: gateway-contracts/tasks/reshareKeys.ts:23,49
Two tasks (task:prssInit, task:keyReshareSameSet) already use useInternalProxyAddress and getRequiredEnvVar but call dotenv.config({ path: path.join(ADDRESSES_DIR, ".env.gateway"), override: true }) directly instead of using loadGatewayAddresses().
Since the gateway utils already have that helper, these should use it for consistency.
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 48 minutes 5 seconds in the queue, including 44 minutes 18 seconds running CI. Required conditions to merge
|
Closes https://github.com/zama-ai/fhevm-internal/issues/395