Skip to content

docs(common): fixes openzeppelin examples and some basic mistakes ins…#2038

Merged
mergify[bot] merged 8 commits intomainfrom
poppyseeddev/docs-fix
Mar 26, 2026
Merged

docs(common): fixes openzeppelin examples and some basic mistakes ins…#2038
mergify[bot] merged 8 commits intomainfrom
poppyseeddev/docs-fix

Conversation

@poppyseedDev
Copy link
Copy Markdown
Contributor

@poppyseedDev poppyseedDev commented Mar 3, 2026

…ide solidityguides

@cla-bot cla-bot bot added the cla-signed label Mar 3, 2026
@mergify
Copy link
Copy Markdown

mergify bot commented Mar 3, 2026 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 44455f2.

🟢 All jobs passed!

But CI Insights is watching 👀

@poppyseedDev poppyseedDev marked this pull request as ready for review March 19, 2026 11:24
@poppyseedDev poppyseedDev requested a review from a team as a code owner March 19, 2026 11:24
@poppyseedDev poppyseedDev requested a review from ankurdotb March 19, 2026 11:31
ankurdotb
ankurdotb requested changes Mar 19, 2026
View reviewed changes
@ankurdotb
Copy link
Copy Markdown
Contributor

ankurdotb commented Mar 24, 2026

@poppyseedDev Let me know when to look again at this? :)

@poppyseedDev
docs(common): address PR #2038 review feedback
f0305f5 
- Use cTOKEN prefix convention instead of wcTOKEN for wrapped tokens
- Remove "experimental library" warning (live on mainnet)
- Merge erc7984-tutorial.md into erc7984.md
- Rename wrapper entry to "ERC-20 to Wrapped ERC-7984" in SUMMARY
- Add OZ-style introductions and 1:1 ratio disclaimers to swap examples
- Update README available guides to reflect changes
@poppyseedDev
Copy link
Copy Markdown
Contributor Author

poppyseedDev commented Mar 25, 2026

@Mergifyio queue

@poppyseedDev poppyseedDev requested a review from ankurdotb March 25, 2026 13:35
@mergify
Copy link
Copy Markdown

mergify bot commented Mar 25, 2026 •
edited
Loading

Merge Queue Status

  • 🟠 Waiting for queue conditions
  • ⏳ Enter queue
  • ⏳ Run checks
  • ⏳ Merge
Required conditions to enter a queue
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue rule main]:
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • base = main
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=do-not-merge
      • any of [🛡 GitHub branch protection]:
        • check-success = common-pull-request/lint (bpr)
        • check-neutral = common-pull-request/lint (bpr)
        • check-skipped = common-pull-request/lint (bpr)
      • any of [🛡 GitHub branch protection]:
        • check-skipped = coprocessor-cargo-test/cargo-tests (bpr)
        • check-neutral = coprocessor-cargo-test/cargo-tests (bpr)
        • check-success = coprocessor-cargo-test/cargo-tests (bpr)
      • any of [🛡 GitHub branch protection]:
        • check-skipped = coprocessor-dependency-analysis/dependencies-check (bpr)
        • check-neutral = coprocessor-dependency-analysis/dependencies-check (bpr)
        • check-success = coprocessor-dependency-analysis/dependencies-check (bpr)
      • any of [🛡 GitHub branch protection]:
        • check-skipped = gateway-contracts-deployment-tests/sc-deploy (bpr)
        • check-neutral = gateway-contracts-deployment-tests/sc-deploy (bpr)
        • check-success = gateway-contracts-deployment-tests/sc-deploy (bpr)
      • any of [🛡 GitHub branch protection]:
        • check-skipped = kms-connector-tests/test-connector (bpr)
        • check-neutral = kms-connector-tests/test-connector (bpr)
        • check-success = kms-connector-tests/test-connector (bpr)

@poppyseedDev
docs(common): drop swapERC7984ToERC7984 example
7e22cad 
The 1:1 ERC-7984 to ERC-7984 swap example is non-sensical — real
token swaps would go through a DEX contract like an AMM.
@poppyseedDev
docs(common): improve ERC7984ERC20Wrapper intro to match OZ docs
2eb82ba 
Add two-step process explanation (token transfer + confidential
minting) as shown in the OZ confidential-contracts documentation.
ankurdotb
ankurdotb reviewed Mar 26, 2026
View reviewed changes
@poppyseedDev
docs(common): resolve merge conflict and add repo links to erc7984
1fbcb88 
Resolve merge conflict in SUMMARY.md keeping the renamed
integration-guide.md from main and the Auctions section from
this branch.

Add Hardhat template and OZ confidential contracts repo links
to erc7984.md as requested in PR review.
@poppyseedDev poppyseedDev force-pushed the poppyseeddev/docs-fix branch from e06c313 to 1fbcb88 Compare March 26, 2026 12:33
@poppyseedDev poppyseedDev requested a review from ankurdotb March 26, 2026 12:34
@poppyseedDev poppyseedDev requested a review from 0xalexbel March 26, 2026 12:45
@mergify
Copy link
Copy Markdown

mergify bot commented Mar 26, 2026 •
edited
Loading

Merge Queue Status

This pull request spent 1 hour 54 minutes 9 seconds in the queue, including 1 hour 39 minutes 43 seconds running CI.

Required conditions to merge

mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify
Merge of #2038
bc3e177
This was referenced Mar 26, 2026
Closed
Merged
@mergify mergify bot mentioned this pull request Mar 26, 2026
Merged
mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify
Merge of #2038
b821886
mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify
Merge of #2038
cfbbea8
mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify
Merge of #2038
4d8b9f9
@mergify mergify bot merged commit 9a232e3 into main Mar 26, 2026
66 of 67 checks passed
@mergify mergify bot deleted the poppyseeddev/docs-fix branch March 26, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankurdotb ankurdotb ankurdotb approved these changes

@0xalexbel 0xalexbel 0xalexbel approved these changes

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@poppyseedDev @ankurdotb @0xalexbel