Skip to content

ci(common): claude review on draft pr#2169

Merged
mergify[bot] merged 1 commit intomainfrom
eudelins/ci/claude-review-draft-pr
Mar 26, 2026
Merged

ci(common): claude review on draft pr#2169
mergify[bot] merged 1 commit intomainfrom
eudelins/ci/claude-review-draft-pr

Conversation

@eudelins-zama
Copy link
Copy Markdown
Contributor

@eudelins-zama eudelins-zama commented Mar 25, 2026

I think we should allow Claude's review on draft PRs.

This allow a first round of AI review before marking the PRs as "Ready for review", which notifies every human reviewers on GitHub attached to the PRs.

(Unfortunately, it seems the only way to test my modification work is to merge the PR...)

@eudelins-zama eudelins-zama self-assigned this Mar 25, 2026
@cla-bot cla-bot bot added the cla-signed label Mar 25, 2026
@eudelins-zama

This comment was marked as outdated.

@eudelins-zama eudelins-zama marked this pull request as ready for review March 25, 2026 08:04
@eudelins-zama eudelins-zama requested a review from a team as a code owner March 25, 2026 08:04
Copy link
Copy Markdown
Contributor

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree but I don't know if I should let infra/security approve

@eudelins-zama
Copy link
Copy Markdown
Contributor Author

Thx @Eikix. We need security team approval to merge this one anyway 😇

Copy link
Copy Markdown
Contributor

@aquint-zama aquint-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm to extend to draft PR

@eudelins-zama
Copy link
Copy Markdown
Contributor Author

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 26, 2026

Merge Queue Status

This pull request spent 2 hours 39 minutes 59 seconds in the queue, including 1 hour 39 minutes 43 seconds running CI.

Required conditions to merge

mergify bot added a commit that referenced this pull request Mar 26, 2026
mergify bot added a commit that referenced this pull request Mar 26, 2026
mergify bot added a commit that referenced this pull request Mar 26, 2026
mergify bot added a commit that referenced this pull request Mar 26, 2026
@mergify mergify bot merged commit afacb2e into main Mar 26, 2026
63 of 64 checks passed
@mergify mergify bot deleted the eudelins/ci/claude-review-draft-pr branch March 26, 2026 15:08
@mergify mergify bot removed the queued label Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants