fix(coprocessor): scheduler, catch panic

[rudy-6-4]

No description provided.

[rudy-6-4]

@claude /pr-review

[claude]

Claude finished @rudy-6-4's request. — View run

[claude]

[AUTOMATED]

Code Review

PR: fix(coprocessor): scheduler, catch panic

Summary

This PR adds resilience to the FHE scheduler by wrapping run_computation() in std::panic::catch_unwind(), converting panics (e.g., from division/remainder overflow in TFHE operations) into structured SchedulerError::ExecutionPanic(String) errors. The changes are well-structured:

1. scheduler.rs: Wraps the computation call with panic catching, extracts the panic message (handling &str, String, and unknown payloads), and properly logs + reports via telemetry.
2. types.rs: Adds ExecutionPanic(String) variant, correctly removes Copy (since String isn't Copy), and adds Display formatting.
3. tfhe_worker.rs: Updates from copy-dereference (*err.downcast_ref()) to .cloned() — necessary and correct change since SchedulerError is no longer Copy.
4. Tests: Comprehensive test that triggers panics via div/rem overflow, verifies errors are properly caught and recorded in the DB with ExecutionPanic messages.

Review Results

Checked for bugs, security issues, guideline compliance, and error handling quality. No issues found.

Key observations:

• The catch_unwind closure correctly satisfies UnwindSafe without needing AssertUnwindSafe — all captured values (i32, Vec, usize, &Vec<u8>) are inherently unwind-safe.
• Panic payload extraction covers the two standard panic types (&str from literal panics, String from formatted panics) with a sensible fallback.
• The ExecutionPanic error correctly falls through to set_computation_error() in the downstream worker — this is the desired behavior since panics during execution represent actual operation failures.
• No panic = "abort" profile is configured, so catch_unwind will work as expected with the default unwind strategy.
• The test infrastructure addition (errors_on_allowed_handles) is clean and reusable.

[claude]

The review has been posted. Here's a summary of what was done:

PR Review Complete: #2170 — fix(coprocessor): scheduler, catch panic

Review Process

• ✅ Pre-review validation: PR is open, non-trivial — review proceeded
• ✅ Bug Hunter (2x opus agents): No bugs found
• ✅ Guideline Compliance: No CLAUDE.md or style guides found in repo — no violations
• ✅ Error Handling Audit: 3 issues raised, all validated as by-design behavior or suggestions (not actual defects)
• ✅ Validation: No issues passed the >= 80 confidence + validation threshold

Verdict: APPROVED ✅

The PR correctly wraps FHE computation in catch_unwind, properly extracts panic messages, adds a new error variant, updates downstream code for the Copy → Clone change, and includes comprehensive tests. No bugs, security issues, or error handling defects were found.

[github-actions]

Changed Lines Coverage

Coverage of added/modified lines: N/A

[Eikix]

clippy fails but otherwise, nice! lgtm

[antoniupop]

LGTM

[rudy-6-4]

@Mergifyio queue

[mergify]

Merge Queue Status

• ✅ Entered queue — 2026-03-26 13:28 UTC · Rule: main
• ✅ Checks passed · on draft merge queue: embarking main (c5bb50b) and [#2169 + #2038 + #2170] together #2186
• ✅ Merged — 2026-03-26 15:09 UTC · at 7afe56e41b54ba9dc2140e35d34c9ae30d1989eb

This pull request spent 1 hour 40 minutes 15 seconds in the queue, including 1 hour 39 minutes 43 seconds running CI.

Required conditions to merge

• #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • ci(common): claude review on draft pr #2169
  • docs(common): fixes openzeppelin examples and some basic mistakes ins… #2038
  • fix(coprocessor): scheduler, catch panic #2170
• #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • ci(common): claude review on draft pr #2169
  • docs(common): fixes openzeppelin examples and some basic mistakes ins… #2038
  • fix(coprocessor): scheduler, catch panic #2170
• #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • ci(common): claude review on draft pr #2169
  • docs(common): fixes openzeppelin examples and some basic mistakes ins… #2038
  • fix(coprocessor): scheduler, catch panic #2170
• branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • ci(common): claude review on draft pr #2169
  • docs(common): fixes openzeppelin examples and some basic mistakes ins… #2038
  • fix(coprocessor): scheduler, catch panic #2170
• check-success = run-e2e-tests / fhevm-e2e-test
• any of [🛡 GitHub branch protection]:
  • check-success = common-pull-request/lint (bpr)
  • check-neutral = common-pull-request/lint (bpr)
  • check-skipped = common-pull-request/lint (bpr)
• any of [🛡 GitHub branch protection]:
  • check-success = coprocessor-cargo-test/cargo-tests (bpr)
  • check-neutral = coprocessor-cargo-test/cargo-tests (bpr)
  • check-skipped = coprocessor-cargo-test/cargo-tests (bpr)
• any of [🛡 GitHub branch protection]:
  • check-success = coprocessor-dependency-analysis/dependencies-check (bpr)
  • check-neutral = coprocessor-dependency-analysis/dependencies-check (bpr)
  • check-skipped = coprocessor-dependency-analysis/dependencies-check (bpr)
• any of [🛡 GitHub branch protection]:
  • check-skipped = gateway-contracts-deployment-tests/sc-deploy (bpr)
  • check-neutral = gateway-contracts-deployment-tests/sc-deploy (bpr)
  • check-success = gateway-contracts-deployment-tests/sc-deploy (bpr)
• any of [🛡 GitHub branch protection]:
  • check-skipped = kms-connector-tests/test-connector (bpr)
  • check-neutral = kms-connector-tests/test-connector (bpr)
  • check-success = kms-connector-tests/test-connector (bpr)