fix(protocol-contracts): add explicit error for stakeExcess underflow (L-04)#1683
Merged
melanciani merged 2 commits intomainfrom Jan 5, 2026
Conversation
🧪 CI InsightsHere's what we observed from your CI run for 8a1183f. 🟢 All jobs passed!But CI Insights is watching 👀 |
melanciani
force-pushed
the
melanciani/fix/protocol-contracts/staking/stakeexcess_explicit_error
branch
from
f3542ee to
8868f62
Compare
jatZama
previously approved these changes
Dec 30, 2025
melanciani
force-pushed
the
melanciani/fix/protocol-contracts/staking/stakeexcess_explicit_error
branch
from
fce907d to
8a1183f
Compare
melanciani
changed the title
jatZama
approved these changes
Jan 5, 2026
melanciani
deleted the
melanciani/fix/protocol-contracts/staking/stakeexcess_explicit_error
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: we decided to also revert if there the excess token is exactly null (as we don't see the point of allowing this)
refs https://github.com/zama-ai/fhevm-internal/issues/826