Skip to content

feat(gateway-contracts): implement coprocessor contexts#211

Closed
melanciani wants to merge 6 commits intofeat/coprocessor_contexts_in_gatewayfrom
roman/107/feat/implement_coprocessor_context
Closed

feat(gateway-contracts): implement coprocessor contexts#211
melanciani wants to merge 6 commits intofeat/coprocessor_contexts_in_gatewayfrom
roman/107/feat/implement_coprocessor_context

Conversation

@melanciani
Copy link
Copy Markdown
Contributor

@melanciani melanciani commented Jun 10, 2025

todo:

  • put back contextId in extraData

what have been done :

  • main logic (cleaned, with code comments)
    • add context ID in VerifyProofRequest event as a new field
    • add context ID in CiphertextVerification struct' as a new field
    • add contexId in VerifyProofResponse event as a new field
      • also add missing extraData field (same for RejectProofResponse)
  • tests
  • documentation
  • compatible with new migration logic
  • add verify task for new contract
  • add contract upgrade tests in CI for updated contracts
  • add getConsensusS3BucketUrls in CiphertextCommits
  • include coprocessor s3 bucket URLs in decryption request event's extraData field
  • clean some eip712 structs from contracts (refs https://github.com/zama-ai/fhevm-internal/issues/403)

also updated spec : https://github.com/zama-ai/tech-spec/pull/292

closes https://github.com/zama-ai/fhevm-internal/issues/439
closes https://github.com/zama-ai/fhevm-internal/issues/172

@melanciani melanciani force-pushed the roman/107/feat/implement_coprocessor_context branch 2 times, most recently from d6e8f16 to e42ed50 Compare June 17, 2025 12:24
@melanciani melanciani force-pushed the roman/107/feat/implement_coprocessor_context branch 9 times, most recently from 0c0e6c6 to e86b236 Compare June 19, 2025 16:39
@melanciani melanciani marked this pull request as ready for review June 19, 2025 16:45
@melanciani melanciani force-pushed the roman/107/feat/implement_coprocessor_context branch from e86b236 to d3aab1a Compare June 19, 2025 17:06
@melanciani melanciani force-pushed the roman/107/feat/implement_coprocessor_context branch from 892a6ba to 4b646c6 Compare June 30, 2025 10:01
@melanciani melanciani requested a review from isaacdecoded June 30, 2025 10:01
@melanciani melanciani force-pushed the roman/107/feat/implement_coprocessor_context branch from 4b646c6 to 11ed791 Compare June 30, 2025 15:53
Copy link
Copy Markdown
Contributor

@isaacdecoded isaacdecoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a great job! 👏

Do you think we should open an issue to unify the imports at some point? 🤔

@melanciani
Copy link
Copy Markdown
Contributor Author

Do you think we should open an issue to unify the imports at some point? 🤔

I'll let you create it yes, it's not urgent at all though no worries

@melanciani melanciani force-pushed the roman/107/feat/implement_coprocessor_context branch from 1ac0f60 to 3b928b7 Compare July 2, 2025 17:30
@cla-bot cla-bot bot added the cla-signed label Jul 7, 2025
@melanciani melanciani force-pushed the roman/107/feat/implement_coprocessor_context branch 2 times, most recently from 65045a8 to 2acc6b4 Compare July 7, 2025 16:39
dartdart26 added a commit that referenced this pull request Sep 24, 2025
Add support for a separate uin256 context ID in the event listened to
by the gw-listener and using it to sign a `CiphertextVerification` in
transaction-sender.

Related to #211
dartdart26 added a commit that referenced this pull request Sep 24, 2025
Add support for a separate uin256 context ID in the event listened to
by the gw-listener and using it to sign a `CiphertextVerification` in
transaction-sender.

Related to #211
dartdart26 added a commit that referenced this pull request Sep 25, 2025
Add support for a separate uin256 context ID in the event listened to
by the gw-listener and using it to sign a `CiphertextVerification` in
transaction-sender.

Related to #211
@melanciani melanciani requested a review from jatZama September 25, 2025 13:10
dartdart26 added a commit that referenced this pull request Sep 25, 2025
Add support for a separate uin256 context ID in the event listened to
by the gw-listener and using it to sign a `CiphertextVerification` in
transaction-sender.

Related to #211
dartdart26 added a commit that referenced this pull request Sep 25, 2025
Add support for a separate uin256 context ID in the event listened to
by the gw-listener and using it to sign a `CiphertextVerification` in
transaction-sender.

Related to #211
Copy link
Copy Markdown
Contributor

@isaacdecoded isaacdecoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

isaacdecoded pushed a commit that referenced this pull request Oct 2, 2025
Add support for a separate uin256 context ID in the event listened to
by the gw-listener and using it to sign a `CiphertextVerification` in
transaction-sender.

Related to #211
@melanciani melanciani force-pushed the roman/107/feat/implement_coprocessor_context branch 3 times, most recently from bdfb2ee to 1054904 Compare October 7, 2025 16:32
@melanciani melanciani marked this pull request as draft October 7, 2025 16:33
@melanciani melanciani force-pushed the roman/107/feat/implement_coprocessor_context branch 3 times, most recently from 1c5440e to 08abc73 Compare October 8, 2025 09:06
@melanciani
Copy link
Copy Markdown
Contributor Author

closing this for now as we'll continue work on this later !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants